Github Reviews vs Reviewboard

[Horacio Duran]

+1 to Github, I prefer the papercuts of githubs to the swordcuts from
reviewboard.

On Fri, Oct 14, 2016 at 12:09 PM, Dimiter Naydenov <
dimiter.naydenov at canonical.com> wrote:

> +1, Nate said what I was thinking :)
>
> On 10/14/2016 05:34 PM, Nate Finch wrote:
> > +1
> >
> > Keeping the PR and reviews together really makes it easier for me to
> > keep track of what's going on with a PR.  It's also really nice not
> > having to context switch out of github for every single PR.
> >
> > Reviewboard and related infrastructure breaks like once couple weeks,
> > and I'm not convinced it'll get better, since we've been using it for
> > quite some time now.
> >
> > I have missed exactly zero of the features of reviewboard since using
> > github, and haven't really cared about the drawbacks of github.
> >
> > One point - you *can* minimize comments in the files view - there's a
> > checkbox per file that will hide the comments in that file.
> >
> > On Fri, Oct 14, 2016 at 8:22 AM roger peppe <rogpeppe at gmail.com
> > <mailto:rogpeppe at gmail.com>> wrote:
> >
> >     On 14 October 2016 at 12:45, Adam Collard
> >     <adam.collard at canonical.com <mailto:adam.collard at canonical.com>>
> wrote:
> >     > Not sure I get a vote, but -1
> >     >
> >     > You're running an old version of ReviewBoard (2.0.12 released in
> >     January
> >     > 2015) and many of the issues I think you've been hitting are fixed
> >     in later
> >     > revisions. Latest stable is 2.5.6.1, 3.0.x is under active
> >     development and
> >     > brings a chunk of new UI improvements.
> >     >
> >     > Release notes for 2.5
> >     >
> >     > 3.0 demo site
> >
> >     I'm still not convinced.
> >
> >     Even 3.0 still deletes draft comments without so much as a
> by-your-leave
> >     when you double-click somewhere else in the text. And because it
> >     doesn't use
> >     real text entry boxes, the Lazarus plugin, my usual saviour in such
> >     cases,
> >     doesn't work. I've lost far too much time to this in the past.
> >
> >     Replying to a comment still involves a page reload and associated
> >     lost context.
> >
> >     I can't see anything in the 2.5 release notes about fixing behaviour
> >     on file
> >     move/rename, though I may well have missed it.
> >
> >     And not being able to deal with really large PRs is a definite issue
> >     too (not
> >     that github is better there).
> >
> >       cheers,
> >         rog.
> >
> >     --
> >     Juju-dev mailing list
> >     Juju-dev at lists.ubuntu.com <mailto:Juju-dev at lists.ubuntu.com>
> >     Modify settings or unsubscribe at:
> >     https://lists.ubuntu.com/mailman/listinfo/juju-dev
> >
> >
> >
>
>
> --
> Dimiter Naydenov <dimiter.naydenov at canonical.com>
> Juju Core Sapphire team <http://juju.ubuntu.com>
>
>
> --
> Juju-dev mailing list
> Juju-dev at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/
> mailman/listinfo/juju-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20161014/119a2de8/attachment.html>