Bad KVM test w.r.t. networking

Dimiter Naydenov dimiter.naydenov at canonical.com
Fri Jul 17 11:52:50 UTC 2015


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 17.07.2015 02:34, Tim Penhey wrote:
> While looking at this bug:
> 
> kvmBrokerSuite worker/provisioner: tests are poorly isolated 
> https://bugs.launchpad.net/juju-core/+bug/1474946
> 
> I came across this function: EnsureRootFSEtcNetwork
> 
> Which was getting called from the KVM broker tests. However it was
> adding /etc/network to the LXC root dir. This is never going to
> have any impact.
> 
> I have renamed the function and stopped calling it from the kvm
> broker test as shown here: http://reviews.vapour.ws/r/2190/diff/#
> 
> However I feel there may be a hole now in the KVM networking
> testing.
> 
> Can someone who knows what they are doing take a look please?
> 
> Cheers, Tim
> 
Good catch and thanks for taking care of this Tim!
I've commented on the bug as well.

- -- 
Dimiter Naydenov <dimiter.naydenov at canonical.com>
Juju Core Sapphire team <http://juju.ubuntu.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAEBAgAGBQJVqOySAAoJENzxV2TbLzHwEtMIAJ4gZ0bA1KxatF89Aj6fh1Im
8k4X3uOsIiDY9nMt173XwvVGtkX1WfItAOSVnsX+FJdW9OuMramaWsBMoJtI01VV
KJCuFRj1AbyrGRbDXNKe7CdTf70E44OVlFU4LhDYYcuTmtuxYg08j80esARa3iTR
ZLHE+iwbwuHamqmLpwe33yeS589alurGDCFOEelRdIbixFzypuaGJ0O/J7ZJKjap
O5Og7LONMuRh/HbxMQyMS1gMmtDfmtj17ZiAM7rcyeoTwYZm8a4IP+weXafOUeME
CFBK7/b5HSegsjnZR2PDUBSDZwe1VMh7NTHmiO+2fzMnXz82XdiWOGNMQc71dR8=
=t7oO
-----END PGP SIGNATURE-----



More information about the Juju-dev mailing list