Public Service Annoucement

[roger peppe]

On 24 April 2015 at 14:21, Martin Packman <martin.packman at canonical.com> wrote:
> On 24/04/2015, David Cheney <david.cheney at canonical.com> wrote:
>> Why doesn't the bot run this hook ?
>
> It does - but there are two problems:
>
> 1) For the gating job to reject the change, the script just has not
> return non-zero. Seems `go tool vet` returns 0 even if it reports
> issues. So, scripts/verify.bash needs updating if you want to fail on
> vet errors.

Are you sure? It seems to return a non-zero exit status for me.

I guess it (and the other point) might be a consequence of running
a different version of govet.

>
> 2) If I download the tarball, and run the verify script in it, I don't
> get any vet issues reported:
>
> ubuntu at go:/tmp/vet$ wget
> http://data.vapour.ws/juju-ci/products/version-2558/build-revision/build-2558/juju-core_1.24-alpha1.tar.gz
> ubuntu at go:/tmp/vet$ tar -xzf juju-core_1.24-alpha1.tar.gz
> ubuntu at go:/tmp/vet$ cd juju-core_1.24-alpha1/src/github.com/juju/juju
> ubuntu at go:/tmp/vet/juju-core_1.24-alpha1/src/github.com/juju/juju$
> GOPATH=/tmp/vet/juju-core_1.24-alpha1 ./scripts/verify.bash
> go version go1.2.1
> checking: go fmt ...
> checking: go vet ...
> checking: go build ...
> checking: tests are wired up ...
>
> If I checkout that git revision (73cde95d) and run the script in tree,
> I do get the vet error.
>
> Basically, make the script fail when you guys want it to fail, and the
> gating job will reject those branches.
>
> Martin
>
> --
> Juju-dev mailing list
> Juju-dev at lists.ubuntu.com
> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev