Test suite on windows now voting on trunk

[Martin Packman]

Last week we resolved a bunch of issues with the test suite, flipped
the switch so it will now mark trunk builds with windows test failures
as not suitable for releasing.

There are three groups of failures in the latest run that still need addressing:

<http://reports.vapour.ws/releases/2549/job/run-unit-tests-win2012-amd64/attempt/276>


FAIL: upgrade_test.go:457: UpgradeSuite.TestUpgradeStepsHostMachine
...
upgrade_test.go:462:
    go func() { c.Check(a.Run(nil), gc.IsNil) }()
... value *errors.errorString = &errors.errorString{s:"cannot create
juju run symlink: symlink
c:\\users\\...\\var\\lib\\juju\\tools\\machine-0\\jujud.exe
c:\\users\\...\\juju-run470635483: GetFileAttributesEx
c:\\users\\...\\var\\lib\\juju\\tools\\machine-0\\jujud.exe: The
system cannot find the path specified."} (...)

This is an unreliable test on several platforms:

<https://bugs.launchpad.net/juju-core/+bug/1444576>

However, there does seem to be an actual issue to resolve here. For
now, skipping it as TestUpgradeStepsStateServer already is on windows
should be fine.


Two failures in MeterStateSuite during setup, with no obvious cause in the logs:

FAIL: meterstatus_test.go:98:
MeterStateSuite.TestMeterStatusWatcherRespondstoMeterStatus
FAIL: meterstatus_test.go:105:
MeterStateSuite.TestMeterStatusWatcherRespondsToMetricsManager
...
meterstatus_test.go:117:
    assertMeterStatusChanged(c, watcher)
meterstatus_test.go:125:
    c.Fatalf("expected event from watcher by now")


Lots of failures on uniter tests, basically all from not finding the
juju tools within hooks:

FAIL: uniter_test.go:1352: UniterSuite.TestActionEvents
FAIL: uniter_test.go:1894: UniterSuite.TestLeadership
FAIL: uniter_test.go:1755: UniterSuite.TestReboot
FAIL: util_windows_test.go:87: UniterSuite.TestRunCommand
FAIL: uniter_test.go:1278: UniterSuite.TestUniterCollectMetrics
FAIL: uniter_test.go:291: UniterSuite.TestUniterConfigChangedHook
FAIL: uniter_test.go:399: UniterSuite.TestUniterDyingReaction
FAIL: uniter_test.go:675: UniterSuite.TestUniterErrorStateUpgrade
FAIL: uniter_test.go:365: UniterSuite.TestUniterHookSynchronisation
FAIL: uniter_test.go:165: UniterSuite.TestUniterInstallHook
FAIL: uniter_test.go:1267: UniterSuite.TestUniterMeterStatusChanged
FAIL: uniter_test.go:1205: UniterSuite.TestUniterRelationErrors
FAIL: uniter_test.go:1085: UniterSuite.TestUniterRelations
FAIL: uniter_test.go:208: UniterSuite.TestUniterStartHook
FAIL: uniter_test.go:448: UniterSuite.TestUniterSteadyStateUpgrade
FAIL: uniter_test.go:1674: UniterSuite.TestUniterSubordinates
...
[LOG] 0:03.493 INFO unit.u/0.install
c:\users\...\agents\unit-u-0\charm>juju-log.exe
deadbeef-0bad-400d-8000-4b1d0d06f00d install
[LOG] 0:03.493 INFO unit.u/0.install 'juju-log.exe' is not recognized
as an internal or external command,
[LOG] 0:03.493 INFO unit.u/0.install operable program or batch file.
...
waiting for hooks: []string{"install", "config-changed", "start"}
ctx.hooksCompleted: []string{"fail-install"}
...
util_test.go:718:
    c.Fatalf("never got expected hooks")


The plan is to resolve these last issues and block on any regressions.
As we start running feature branches through CI, these too will be
marked as unmergable if they fail unit tests on windows.

Martin