is peergrouper spam worth having in the Log?

[Tim Penhey]

Do it!

Tim

On 07/04/15 03:32, Nate Finch wrote:
> Along the same lines as the other logging thread... the peergrouper runs
> every minute and spits out 11 log messages, some of which wrap to 3+
> lines long, all of which to say "there's nothing to do".  This happens
> for every state server, which means at least 33 log messages every
> minute in the all-machines.log which is basically entirely useless, and
> obscures anything else that might be going on in the log.
> 
> What do people think about making this trace level as well?  Certainly
> logging if something needs changing is worth logging higher, but the
> rest really seems like it is more trace-level logging than something
> that would actually be useful in debugging.
> 
> An example here:
> 
> 2015-04-06 04:41:31 DEBUG juju.worker.peergrouper publish.go:47 API host
> ports have not changed
> 2015-04-06 04:41:31 DEBUG juju.worker.peergrouper desired.go:38
> calculating desired peer group
> 2015-04-06 04:41:31 DEBUG juju.worker.peergrouper desired.go:39 members:
> map[*peergrouper.machine]*replicaset.Member{&peergrouper.machine{
> id: "0", wantsVote: true, hostPort: "10.147.162.252:37017
> <http://10.147.162.252:37017>"}:(*replicaset.Member)(0xc210574fa0),
> &peergrouper.machine{id: "1", wantsVote: t
> rue, hostPort: "10.28.202.234:37017
> <http://10.28.202.234:37017>"}:(*replicaset.Member)(0xc210550000),
> &peergrouper.machine{id: "2", wantsVote: true, hostPort: "10.4.8
> 7.231:37017"}:(*replicaset.Member)(0xc210550050)}
> 2015-04-06 04:41:31 DEBUG juju.worker.peergrouper desired.go:40 extra:
> []replicaset.Member(nil)
> 2015-04-06 04:41:31 DEBUG juju.worker.peergrouper desired.go:41 maxId: 3
> 2015-04-06 04:41:31 DEBUG juju.worker.peergrouper desired.go:110
> assessing possible peer group changes:
> 2015-04-06 04:41:31 DEBUG juju.worker.peergrouper desired.go:116 machine
> "0" is already voting
> 2015-04-06 04:41:31 DEBUG juju.worker.peergrouper desired.go:116 machine
> "1" is already voting
> 2015-04-06 04:41:31 DEBUG juju.worker.peergrouper desired.go:116 machine
> "2" is already voting
> 2015-04-06 04:41:31 DEBUG juju.worker.peergrouper desired.go:134 assessed
> 2015-04-06 04:41:31 DEBUG juju.worker.peergrouper worker.go:284 no
> change in desired peer group (voting map[*peergrouper.machine]bool{&pee
> rgrouper.machine{id: "0", wantsVote: true, hostPort:
> "10.147.162.252:37017 <http://10.147.162.252:37017>"}:true,
> &peergrouper.machine{id: "1", wantsVote: true, hostPort
> : "10.28.202.234:37017 <http://10.28.202.234:37017>"}:true,
> &peergrouper.machine{id: "2", wantsVote: true, hostPort:
> "10.4.87.231:37017 <http://10.4.87.231:37017>"}:true})
> 
> 
>