Is ReviewBoard a good thing?
David Cheney
david.cheney at canonical.com
Fri Sep 19 00:32:54 UTC 2014
There were three problem reviewboard was supposed to address, review
comments are sent immediately, no side by side diffs, and no way to to
chained proposals.
I think that over the last few months we've all learnt to live with
the first issue
On the second, github now does nice side by side diffs.
On the third, it appears reviewboard leaves you solidly to your own
devices to implement chained proposals.
I'm with Jesse, I vote to stop using reviewboard, I don't think it's
paying it's way.
On Fri, Sep 19, 2014 at 10:19 AM, Jesse Meek <jesse.meek at canonical.com> wrote:
> We moved to GitHub in the hope of lowering the bar to contributors outside
> the team. GitHub is *the* platform and process for open source software.
> This was the logic behind the move. It was deemed to have the most mindshare
> and we sacrificed our prefered platform and process to be part of that
> mindshare.
>
> We are now leaving that 'main stream' process to something that suits the
> tastes of our team - ReviewBoard. This adds friction for new contributors
> (friction everyone has experienced this week). If we value our preferred
> methods of reviewing over keeping to a well known process for outside
> contributors, the best process was launchpad + rietveld. Shouldn't we simply
> return to that.
>
> Considering we have been successfully using GitHub for several months now,
> using reviewboard is not a necessity. Obviously, I will go with whatever the
> team decides, but I'm concerned that we have moved to reviewboard without
> considering that it undermines (as far as I can see) our primary reason for
> using GitHub.
>
> Jess
>
> --
> Juju-dev mailing list
> Juju-dev at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
More information about the Juju-dev
mailing list