Doing chained diffs w/ Reviewboard

[David Cheney]

And another thing. Why does reviewboard have at least two ways to do
everything, with different results.

Case in point, if I use the "add comment" option on a review comment,
those comments are not visible straight away, fine, i can see that,
the little icon on the dashboard says they are in draft. So, how do
you publish those ? Do you use the "review" button on the top right ?
You can, it will publish something, but your comments are still in
draft,you have to scroll down, find the tiny "publish", or "discard"
buttons nestled between the open issues and the diff body and push
that.

On Thu, Sep 18, 2014 at 9:06 PM, David Cheney
<david.cheney at canonical.com> wrote:
> Also, be watchful for the other reviewboard footgun, paged diffs.
>
> Reviewboard pages large reviews, so if you're used to thinking 'phew,
> i've gotten to the end of the page, i'm done", check again, there
> maybe a surprise waiting for you at the bottom of the page.
>
> On Thu, Sep 18, 2014 at 9:03 PM, David Cheney
> <david.cheney at canonical.com> wrote:
>> +1 to that
>>
>> On Thu, Sep 18, 2014 at 7:53 PM, Adam Collard
>> <adam.collard at canonical.com> wrote:
>>> On 18 September 2014 10:49, John Meinel <john at arbash-meinel.com> wrote:
>>>>
>>>> Has anyone succeeded in getting this to work?
>>>>
>>>> The steps I tried to do were:
>>>>
>>>>  git co master
>>>>  git pull upstream master
>>>>  git co base-branch
>>>>  git diff master... > base.diff
>>>>  git co dependent-branch
>>>>  git diff master... > dependent.diff
>>>>  git merge-base master HEAD > remember-this-rev
>>>>
>>>> And then put the "dependent.diff" into the "Diff: *", and then the
>>>> "base.diff" into "Parent Diff:" and then 'remember-this-rev' into the Base
>>>> Commit ID.
>>>>
>>>> I also tried putting "git merge-base master base-branch" as the Base
>>>> Commit ID.
>>>
>>>
>>> This makes me think you're using the UI to do this.
>>>
>>> Let me repeat my Public Safety Announcement: Do NOT use ReviewBoard's UI for
>>> uploading diffs. Please for $deity's sake use rbt post.
>>>
>>> https://www.reviewboard.org/docs/rbtools/0.6/rbt/commands/post/#distributed-version-control-systems
>>>
>>> --
>>> Juju-dev mailing list
>>> Juju-dev at lists.ubuntu.com
>>> Modify settings or unsubscribe at:
>>> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>>>