ReviewBoard is now the official review tool for juju

Eric Snow eric.snow at canonical.com
Mon Sep 15 19:23:58 UTC 2014


On Mon, Sep 15, 2014 at 12:54 PM, Dimiter Naydenov
<dimiter.naydenov at canonical.com> wrote:
> - From my meager experience with writing git plugins (any executable in
> $PATH with "git-" prefix), what are you describing can be easily
> achieved. If you write a git plugin, named e.g. "git-rbpropose", using
> the GitHub CLI (https://github.com/github/hub) and rbt, you can
> automate the process:
>  1. Pushing the branch to origin (checking for uncommitted changes).
>  2. Creating a GitHub PR for the branch, which includes launching the
> default editor to fill-in the PR description (using hub).
>  3. Creating a RB review (using rbt).
>  4. Optionally opening the default browser with it.
>
> I have a couple of handy scripts that do this, which I've shared before:
> git-sync (), and git-propose (), along with a few aliases (). git-sync
> fits especially well with the RB workflow, because it pull
> upstream/master into your local repo's master, then pushes it back to
> origin/master, and finally (when you're on a branch other than master)
> rebases all branch commits over origin/master, interactively. What
> usually do is run "git propose" after the finaly "git sync" to create
> a PR - the only thing missing is the RB steps.

Cool.  I'll take a look.

>
> Cheers and thanks for all the hard work around putting RB workflow in
> place,

Glad to do it. :)

-eric



More information about the Juju-dev mailing list