reviewboard

[Eric Snow]

On Mon, Sep 8, 2014 at 4:37 AM, Ian Booth <ian.booth at canonical.com> wrote:
> Hi Eric
>
> Fantastic, thank you.
>
> Quick question - can we set up a Juju team group and have that group
> automatically be assigned as a reviewer for newly created review requests? I
> tried to create a new request using the web ui and had to manually enter the
> reviewer. Except there was no group set up yet for the Juju team.

I've added a review group ("juju-team") and a default reviewer
("juju-tream") with that group (and all repos) assigned to it.  As we
add repos and users I'll make sure that stays up to date.

>
> Also, when creating a new review request, it shows a list of commits to choose
> from, whereas I would be wanting to see a list of branches since that's how we
> create the PRs on Github and the branch is what the review is based on. Can we
> fix this?

Unfortunately reviewboard doesn't support github PRs and they don't
plan on supporting it.  At some point I'd like to add support for
automatically generating review requests from pull requests and
automatically notifying the CI bot when a review request gets a
ship-it.

In the meantime I recommend using rbt (as echoed by Adam).  I know
As a bonus, rbt allows you to create review requests relative to a
parent revision (ergo branch), so you can chain patches.

-eric