reviewboard-github integration

[Ian Booth]

Hi Eric

I just created a pull request for a 1.20 branch and got the same symptoms as
seen previously. ie an incomplete review board review without a diff and with a
reviewer.

On 21/10/14 07:38, Eric Snow wrote:
> This should be resolved now.  I've verified it works for me.  If it
> still impacts anyone, just let me know.
> 
> -eric
> 
> On Mon, Oct 20, 2014 at 7:34 PM, Eric Snow <eric.snow at canonical.com> wrote:
>> Yeah, this is the same issue that Ian brought up.  I'm looking into
>> it.  Sorry for the pain.
>>
>> -eric
>>
>> On Mon, Oct 20, 2014 at 5:31 PM, Dimiter Naydenov
>> <dimiter.naydenov at canonical.com> wrote:
> Hey Eric,
> 
> Today I tried proposing a PR and the RB issue (#202) was created, but
> it didn't have "Reviewers" field set (as described below), it wasn't
> published (due to the former), but MOST importantly didn't have a diff
> uploaded. After fiddling around with rbt I managed to do:
> $ rbt diff > ~/patch
> (while on the proposed feature branch)
> 
> And then went to the RB issue page and manually uploaded the generated
> diff and published it.
> 
> So most definitely the hook generating RB issues have to upload the
> diff as well :)
> 
> It's coming together, keep up the good work!
> 
> Cheers,
> Dimiter
> 
> On 20.10.2014 16:53, Eric Snow wrote:
>>>>> On Mon, Oct 20, 2014 at 6:06 AM, Ian Booth
>>>>> <ian.booth at canonical.com> wrote:
>>>>>> Hey Eric
>>>>>>
>>>>>> This is awesome, thank you.
>>>>>>
>>>>>> I did run into a gotcha - I created a PR and then looked at the
>>>>>> Incoming review queue and there was nothing new there. I then
>>>>>> clicked on All in the Outgoing review queue and saw that the
>>>>>> review was unpublished. I then went to publish it and it
>>>>>> complained at least one reviewer was needed. So I had to fill in
>>>>>> "juju-team" and all was good.
>>>>>>
>>>>>> 1. Can we make it so that the review is published automatically?
>>>>>> 2. Can we pre-fill "juju-team" as the reviewer?
>>>>>
>>>>> Good catch.  The two are actually related.  The review is
>>>>> published, but that fails because no reviewer got set.  I'll get
>>>>> that fixed.
>>>>>
>>>>> -eric
>>>>>
> 
> 
>>>
>>> --
>>> Juju-dev mailing list
>>> Juju-dev at lists.ubuntu.com
>>> Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev