reviewboard-github integration

Eric Snow eric.snow at canonical.com
Mon Oct 20 13:53:56 UTC 2014


On Mon, Oct 20, 2014 at 6:06 AM, Ian Booth <ian.booth at canonical.com> wrote:
> Hey Eric
>
> This is awesome, thank you.
>
> I did run into a gotcha - I created a PR and then looked at the Incoming review
> queue and there was nothing new there. I then clicked on All in the Outgoing
> review queue and saw that the review was unpublished. I then went to publish it
> and it complained at least one reviewer was needed. So I had to fill in
> "juju-team" and all was good.
>
> 1. Can we make it so that the review is published automatically?
> 2. Can we pre-fill "juju-team" as the reviewer?

Good catch.  The two are actually related.  The review is published,
but that fails because no reviewer got set.  I'll get that fixed.

-eric



More information about the Juju-dev mailing list