Landing job uses pre-push script

[Andrew Wilkins]

On Thu, Oct 2, 2014 at 1:35 PM, Martin Packman <martin.packman at canonical.com
> wrote:

> The landing job for juju now uses the pre-push script from the juju
> branch before running tests. This means it's running go vet over the
> source, and I've fixed a couple of errors on master.
>

Great, thanks Martin.


> What it doesn't do currently is fail the landing if vet reports
> issues, as the script doesn't fail in this case. If we want to make go
> vet issues gate the landing of code, we can just land that change to
> the pre-push script.


IIRC, "go tool vet" will only set an error return code when invoked on a
package or files, rather than on a directory. I think it's a matter of
checking whether "go tool vet" prints any warnings, rather than relying on
the return code. Or xargs and get the RC.


> Martin
>
> --
> Juju-dev mailing list
> Juju-dev at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20141003/113e5ff0/attachment-0001.html>