Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo)

[Curtis Hovey-Canonical]

On Wed, May 14, 2014 at 8:12 AM, John Meinel <john at arbash-meinel.com> wrote:
> I'd like gccgo to pass reliably, but I think it falls under a CI test rather
> than a pre-commit test. (Because otherwise it roughly doubles the time it
> takes to know whether your patch will land.)

I agree. We can setup gccgo-based test runs for libraries on amd64 and
ppc. I am not certain about priorities. Is getting juju into github
more important?

> On Wed, May 14, 2014 at 1:24 PM, Tim Penhey <tim.penhey at canonical.com>
> wrote:
>> I took it upon myself to get Rog's errgo library used inside juju-core.

>> I have a branch of juju-core up as work in progress that does the
>> following:
>>  * removes the dependency on github.com/errgo/errgo
>>  * changes uses of errgo/errgo to juju/errors
>>  * adds both juju/errgo and juju/errors to the dependency file
>>  * removes the juju-core/errors package
>>  * changes all the juju-core/errors import statement to use
>>    github.com/juju/errors (and puts the import statement in the
>>    right block)

I predict 1.18 will fail in CI. because it will still want errgo,
which go-get did will not get. Something similar happened with when
1.17.x dropped a dep that 1.16.x wanted. I will add a shim to keep
1.18 building.



-- 
Curtis Hovey
Canonical Cloud Development and Operations
http://launchpad.net/~sinzui