End Of Review marker

Horacio Duran horacio.duran at canonical.com
Thu Jun 12 10:38:10 UTC 2014


Hey, I don't know if this bugs everyone or just me but it happens very
often that I am working while people are reviewing my code on gh. While
people is reviewing and commenting on the code I keep getting mails and the
diff page from the pr keeps changing. To know when its all done and I can
finally try to answer/fix all the comments I usually wait until my phone
stops ringing madly with mails but I think that we could do better. At the
end of the diff page there is a comment box where you can add comments
(where you usually add your $$merge$$ or LGTM) We could add something
there, like "Done" just to let the author know we are done with the review
and not just reading a big confusing chunk of code.
What do you people think?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140612/45e55785/attachment.html>


More information about the Juju-dev mailing list