Reviewing in progress work on Github

[Richard Harding]

I've been wanting to get a few minutes of spare time to try out
reviewboard. It's python based, has a charm (though it's outdated) and is
supposed to be nice to use, though I've not used it in any anger yet.

http://www.reviewboard.org/

Rick

On Fri, 06 Jun 2014, Menno Smits wrote:

> If we're finding too many shortcomings with the GH code review system we
> could look at Gerrit or something else.
>
> It looks like people have already done Gerrit/Github integration before:
> http://gerrithub.io/
> http://www.packtpub.com/article/using-gerrit-with-github
>
>
>
> On 6 June 2014 12:06, Andrew Wilkins <andrew.wilkins at canonical.com> wrote:
>
> > On Thu, Jun 5, 2014 at 9:26 PM, roger peppe <rogpeppe at gmail.com> wrote:
> >
> >> On 5 June 2014 14:22, Andrew Wilkins <andrew.wilkins at canonical.com>
> >> wrote:
> >> > On Thu, Jun 5, 2014 at 9:02 PM, roger peppe <rogpeppe at gmail.com> wrote:
> >> >>
> >> >> On 5 June 2014 05:07, Menno Smits <menno.smits at canonical.com> wrote:
> >> >> > One nice feature is that old comments are hidden
> >> >> > if the area of the code they reference is changed by a later diff.
> >> >>
> >> >> I consider this a serious shortcoming. I generally want to see all the
> >> >> conversation for a given code review. Is it possible to reveal
> >> >> the old comments somehow?
> >> >
> >> >
> >> > See the comment history on: https://github.com/juju/juju/pull/8
> >> >
> >> > - I proposed, and jam made some comments
> >> > - I addressed the comments in a new commit, rebased and squashed it
> >> into the
> >> > old, and did a "git push -f"
> >> >
> >> > There's now a "jameinel commented on an outdated diff". Click on "Show
> >> > outdated diff" to the right, and you can see the old comments.
> >> >
> >> > (I was under the impression that old comments got dropped altogether
> >> after
> >> > rebase. Not sure if behaviour in GitHub changed at some point, or if it
> >> was
> >> > always like this...)
> >>
> >> Ah, that's better than I thought, thanks.
> >>
> >> Is there a straightforward way of seeing the changes made in response
> >> to a particular I(outdated) comment? That's something I did almost every
> >> time in Rietveldt.
> >>
> >
> > Not AFAIK. I miss this too.
> >