Reviewing in progress work on Github

[Andrew Wilkins]

On Thu, Jun 5, 2014 at 9:02 PM, roger peppe <rogpeppe at gmail.com> wrote:

> On 5 June 2014 05:07, Menno Smits <menno.smits at canonical.com> wrote:
> > One nice feature is that old comments are hidden
> > if the area of the code they reference is changed by a later diff.
>
> I consider this a serious shortcoming. I generally want to see all the
> conversation for a given code review. Is it possible to reveal
> the old comments somehow?


See the comment history on: https://github.com/juju/juju/pull/8

- I proposed, and jam made some comments
- I addressed the comments in a new commit, rebased and squashed it into
the old, and did a "git push -f"

There's now a "jameinel commented on an outdated diff". Click on "Show
outdated diff" to the right, and you can see the old comments.

(I was under the impression that old comments got dropped altogether after
rebase. Not sure if behaviour in GitHub changed at some point, or if it was
always like this...)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140605/e35934ce/attachment.html>