Reviewing in progress work on Github

[Ian Booth]

You can, but then you loose any previous comments and history on the previously
work in progress pull request. With Launchpad, you could just flip the status on
the merge proposal and all the comments would be retained.

On 05/06/14 13:38, John Meinel wrote:
> Can't you just create a new Pull request when it is finally ready?
> 
> John
> =:->
> 
> 
> 
> On Thu, Jun 5, 2014 at 7:25 AM, Ian Booth <ian.booth at canonical.com> wrote:
> 
>> One of the many things I miss now that we have moved to Github/git is the
>> ability to put up a merge proposal with in-progress work, allowing
>> collaboration
>> on the implementation as it evolves etc. Launchpad supported this nicely,
>> as it
>> didn't spam people with emails for wip mps etc.
>>
>> I don't think Github supports this concept. Perhaps a way around it is to
>> do a
>> pull request against one's forked copy of the main Juju repo. That way,
>> people
>> can still easily see your work, but without the general spam. Sadly, it
>> doesn't
>> allow the pull request to then be re-targetted to the Juju repo when ready
>> to be
>> reviewed for real. Or does it?
>>
>> Does anyone have any better ideas how to do this?
>>
>> --
>> Juju-dev mailing list
>> Juju-dev at lists.ubuntu.com
>> Modify settings or unsubscribe at:
>> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>>
>