Commented-out tests?

[Gustavo Niemeyer]

On Fri, Aug 29, 2014 at 4:28 PM, Katherine Cox-Buday
<katherine.cox-buday at canonical.com> wrote:
> Hey all,
>
> I ran into some commented out tests while making a change:
> https://github.com/juju/juju/pull/630/files#r16874739
>
> I deleted them since keeping things around that we might need later is the
> job of source control, not comments ;)

If it was a relevant test, removing them generally means they're never
coming back. The best course of action might be to Skip it or to use
ExpectFailure, providing an appropriate reason string. This makes it
visible that there are tests not being run or failing, while still
making sure they at least build.

Of course, if they're indeed never coming back, then just removing
them for good is more honest.


gustavo @ http://niemeyer.net