Commented-out tests?

[Nate Finch]

Git blame says ask Roger ;)

100% agree... don't leave in commented out code.

If you feel you must, because you expect it to get uncommented very soon,
then leave a very clear comment about why it was commented out and when it
should get uncommented.

But mostly just don't.


On Fri, Aug 29, 2014 at 3:28 PM, Katherine Cox-Buday <
katherine.cox-buday at canonical.com> wrote:

> Hey all,
>
> I ran into some commented out tests while making a change:
> https://github.com/juju/juju/pull/630/files#r16874739
>
> I deleted them since keeping things around that we might need later is the
> job of source control, not comments ;)
>
> Ian just wanted me to check just to make sure this was OK. If not, please
> chime in on the PR ASAP.
>
> Thanks all!
>
> -
> Katherine
>
> --
> Juju-dev mailing list
> Juju-dev at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140829/d1b01644/attachment.html>