changing the simplestreams filename format

[Gabriel Samfira]

Hi Andrew,

The juju-metadata command generates simplestreams files to be used in private clouds for example. Both:

juju-metadata generate-tools
and
juju-metadata generate-image

will output files containing ":".

We also care during testing, when the tests use local storage to save the metadata files. A quick snippet of a failing test bellow:

simplestreams_test.go:372:
    s.assertWriteMetadata(c, false)
testing/testing.go:108:
    c.Assert(err, gc.IsNil)
... value *os.LinkError = &os.LinkError{Op:"replace", Old:"C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\1\\gocheck-89438594918
3117216\\0\\.tmp\\juju-filestorage-736520790", New:"C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\1\\gocheck-894385949183117216
\\0\\tools\\streams\\v1\\com.ubuntu.juju:released:tools.json", Err:0x7b} ("replace C:\\Users\\ADMINI~1\\AppData\\Local\\Temp
\\1\\gocheck-894385949183117216\\0\\.tmp\\juju-filestorage-736520790 C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\1\\gocheck-8
94385949183117216\\0\\tools\\streams\\v1\\com.ubuntu.juju:released:tools.json: The filename, directory name, or volume label syntax is incorrect.")


Regards,
Gabriel

On 22.08.2014 04:54, Andrew Wilkins wrote:
On Fri, Aug 22, 2014 at 4:37 AM, Nate Finch <nate.finch at canonical.com<mailto:nate.finch at canonical.com>> wrote:
Simplestreams generates files with names like this:

http://maas.ubuntu.com/images/ephemeral-v2/daily/streams/v1/com.ubuntu.maas:daily:v2:download.sjson

Unfortunately, the colons in the filename are illegal on Windows, which complicates getting tests running on Juju, and getting a fully-functional juju on Windows.

Dumb question: when/where do we care? A URL is not a filesystem path, and we don't store simplestreams metadata on disk other than in provider storage as far as I'm aware. Provider storage is only on-disk for manual/local bootstrap nodes (for now).

I brought this up with Scott Moser, and it sounds like it might not be the end of the world to change the delimiter that is used to be something Windows-friendly.

I wanted to bring this up on juju-dev in case there are juju-specific concerns about the proposed change to the filenames.

I'm new to simplestreams, so I'm sure there are nuances I don't understand, which is why I'm posting it here.

-Nate



--
Juju-dev mailing list
Juju-dev at lists.ubuntu.com<mailto:Juju-dev at lists.ubuntu.com>
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140822/2e561551/attachment-0001.html>