Label: Ready For Review

[Nate Finch]

Hmm, that's a good point.  This whole "only owners can label stuff" is
annoying.

I wonder if we should just make everyone owners.
On Aug 11, 2014 5:59 PM, "David Cheney" <david.cheney at canonical.com> wrote:

> What if the review needs the author to rework ?
>
> On Tue, Aug 12, 2014 at 7:55 AM, Nate Finch <nate.finch at canonical.com>
> wrote:
> > Merge it and it'll get closed and out of the list of open PRs.  I presume
> > the submitter is paying enough attention to merge their own stuff.
> >
> > On Aug 11, 2014 5:44 PM, "David Cheney" <david.cheney at canonical.com>
> wrote:
> >>
> >> How can we remove the label once the review has been done ?
> >>
> >> On Tue, Aug 12, 2014 at 4:33 AM, Nate Finch <nate.finch at canonical.com>
> >> wrote:
> >> > I made a label on github.com/juju/juju (and coincidentally
> >> > github.com/juju/utils) called Ready For Review. The reason for the
> label
> >> > is
> >> > that it is often difficult to figure out what branches are actually
> >> > ready to
> >> > be reviewed and which ones are really WIP and therefore aren't waiting
> >> > to be
> >> > reviewed.  It's simple to filter by labels to see what's assigned to
> >> > Ready
> >> > For Review, so the on-call reviewers (or anyone else) can find stuff
> to
> >> > review.
> >> >
> >> > I did this because some people had mentioned to me that they had
> >> > branches
> >> > that were waiting for reviews, but no one was reviewing them.  Pinging
> >> > people who are online works, but it's hard to ping people who aren't
> >> > online.... so I figured this was easier and gives everyone somewhere
> to
> >> > go
> >> > to find what PR's are languishing.
> >> >
> >> > I know we have the WIP: prefix for branches that aren't ready to be
> >> > generally reviewed.... but that's opt-out, which means it's easy to
> >> > forget
> >> > to put that on your branch and have people think it's ready for review
> >> > when
> >> > it's not....  which means people tend to err on the side of just not
> >> > reviewing stuff.  The Ready For Review label is opt-in, so there's no
> >> > doubt
> >> > that the submitter thinks it's ready.
> >> >
> >> > It currently requires someone on this list to add the label (at least
> >> > for
> >> > github.com/juju/juju), which is somewhat unfortunate, but it's really
> >> > only
> >> > needed if you think your code won't get reviewed otherwise... and
> maybe
> >> > just
> >> > asking someone to add that label will encourage them to review your
> >> > code.
> >> >
> >> > -Nate
> >> >
> >> > --
> >> > Juju-dev mailing list
> >> > Juju-dev at lists.ubuntu.com
> >> > Modify settings or unsubscribe at:
> >> > https://lists.ubuntu.com/mailman/listinfo/juju-dev
> >> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140811/0b1adc9e/attachment.html>