avoiding unnecessarily entering "upgrade mode"

[Menno Smits]

On 6 August 2014 18:32, John Meinel <john at arbash-meinel.com> wrote:

> That sounds like what I would have expected was happening (we only run
> upgrade steps if we think they have a reason to change things, and then
> only set the last known version once all the upgrade steps have finished.)
>

> I'm concerned about the "if there is a mongo problem", because if we're
> running into problems for things we think are idempotent, then we might
> have a genuine problem with them.
>

Sorry, I wasn't clear. I didn't mean to imply there were any problems with
existing upgrade steps. I was referring to the recent mongo replicaset
problems we've been having - they were sometimes preventing the
upgrade-steps worker from finishing so we never came out of "upgrade mode"
causing many "upgrade in progress" messages to be spewed to the logs.

By making the change I'm proposing, we can avoid the unnecessary and
confusing log noise in the case where no upgrade needs to be performed.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140811/3770b08a/attachment.html>