Jujued logs

[Ian Booth]

Bug 1161660 filed.

I'm away on holidays for 2 weeks so I'll leave it to the good folks on juju-core
squad or Blue squad to fit into the schedule.

On 29/03/13 08:48, Gustavo Niemeyer wrote:
> On Thu, Mar 28, 2013 at 7:34 PM, Ian Booth <ian.booth at canonical.com> wrote:
>> I agree, it's been annoying me too. The rationale behind it is that the format
>> of the log messages is:
>> <datetime> <severity> JUJU:<cmd> <msg text>
>>
>> where, if command is a subcommand, it prints as <super cmd>:<cmd>
>>
>> However, super command is always "juju" so that can easily be dropped from the
>> command name rendering.
> 
> This would be nice.
> 
>> As for the "cmd/juju" bit, that comes from the actual log message:
>>
>> log.Infof("cmd/juju: looking blah blah...")
>>
>> This would have been from before the log messages were formatted to include
>> standard fields and people had to add this sort of stuff ad hoc. So it's just a
>> matter of removing such text, and ensuring we do not add this sort of (now)
>> redundant information in the future to the message text itself.
> 
> Agreed, this sounds good. We'll just need to change the format a bit
> so that the command name doesn't get mixed with the message. I've
> dropped the cmd/foo bit here and we end up with something like:
> 
>   2013/03/28 18:42:10 INFO JUJU:juju:publish charm sent; waiting for
> it to be published...
> 
> "publish" is the command name.. it's not the "publish charm". We need
> a field separator there as well.
> 
> 
> gustavo @ http://niemeyer.net
>