EOD 2013-01-21

Martin Packman martin.packman at canonical.com
Mon Jan 21 20:10:30 UTC 2013


Ian asked in the standup if I could land my branch with the
secgroup-delete-all tool as he had a use for it the other day.

However, I didn't want to merge it with no tests - especially as it
seems just running `go test ./...` doesn't fail if there are build
problems in a package without a test file. It turns out writing tests
using our current testservice doubles is pretty painful, and it's
still not possible to properly cover error cases.

I've reproposed the branch with a couple of test cases added, if
anyone wants to have a look:

https://codereview.appspot.com/6948051/

In particular:
* I'd like to write proper unit tests but we're stuck with end-to-end
testing mostly.
* I don't see how to test the basics of command line behaviour with
gnuflag magic involved.
* There's no way to set up state for novaservice currently, and its
internals are private.
* We have no way make our test services return errors on demand.
* The http response code of the delete call tested was wrong in the double.
* There is a lot of setup required and not much in the way of shortcuts.

Martin



More information about the Juju-dev mailing list