Symlinks in juju-core

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

...
>> Is that reasonable? The alternative is to have it try to symlink
>> if it can, and then fall back to directory copies. Which would
>> let you use symlinks if the platform supports it.

...

> That is, we're probably copying everything that matters anyway, and
> what we're not copying we probably should be; so, I wouldn't expect
> the difference made by a few extra copies in a few extra cases to
> be significant, and I think I would willingly pay a small
> performance cost in exchange for simple cross-platform tests.
> 
> Cheers William

I removed the symlinks, and 'go test ./...' passes. (I had a test fail
here and there, but nothing reproducible, so I think those are just
unstable tests.)

I did try removing the whole directory and tests failed. Digging
further it looks like "testing.Charms.Bundle*" functions moderate
access to the actual charms, and take a series parameter. However all
callers pass the string "series" rather than an actual series.

So removing them seems fine. The only remaining pieces is that there
is a symlink in the 'dummy' charm, which I imagine is to make sure
symlinks get treated correctly when bundling charms. So that is
something I'll look to make lazy created, and skip those tests on
platforms that don't support symlinks.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlETmEAACgkQJdeBCYSNAAP2mACffGda6uCsYyt7U3AYGvP+Tpp5
tMcAoMcTyphVR7DJF3kNqXe0NseCpnqU
=Eqly
-----END PGP SIGNATURE-----