Taking over lp:~gz/juju-core/status_api
Dimiter Naydenov
dimiter.naydenov at canonical.com
Fri Dec 20 15:36:56 UTC 2013
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Martin,
On 20.12.2013 16:31, Martin Packman wrote:
> On 20/12/2013, Dimiter Naydenov <dimiter.naydenov at canonical.com>
> wrote:
>>
>> Since Martin is on leave and his branch
>> lp:~gz/juju-core/status_api seems almost ready to land, I decided
>> to take it over and land it.
>
> Thanks Dimiter.
>
> Was going to land the other evening, but wasn't sure the failing
> state/apiserver/client tests were okay without also fixing the
> 'agent-state: missing' part as status also needs to access the
> environ.
All that is tested separately, so the apiserver/client tests are just
a formality, to test the transport. I also tested the changes live on
EC2 and everything seems to be just fine.
>
> One question, rather than merging my branch, you seem to have
> imported the diff, chucking away all of my branch's history. Was
> there a reason for that? Makes it harder to see what changes to
> added to fix those tests I was curious about.
My bad :/ It stems from my lack of sufficient bzr/lp knowledge on how
to do that, and there was nobody around to ask. I'm sure a diff or my
and your branch over the changed files will reveal all important things.
>
> Martin
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJStGQYAAoJENzxV2TbLzHwjFgIAJqNEBuaZCxwoEBdnQlC6cNm
3DBxUC6XEA1RSkRdOyEGVXXWcBkHcxkNA87SPcR1Zl7fj2XiATtsYLYYGBLAI+/2
jYDhwq6Clli+0qj3ew7aotMsnQ6MoSG24hMQUV4JRq/kBw4NTma0ucn9opyxW1jy
Bp4sAbfXCTQFxWV85+bM6fUwGk8lwoHNWQ1bDqxnmF2DkMBYHglj2cTTuklF1eO3
Rd6xttsTQK09jG4Ih5ZMLublkJUFpWdh2D+xTR7oI+HmGUkUt8MY+hMs+P7p74MG
pTSzF3+xRGE0gLne9XiUMZlfImNnU6AR7x9NxXa7MixXLZgF5ek1SMA1t0wLzlU=
=es82
-----END PGP SIGNATURE-----
More information about the Juju-dev
mailing list