removing state.address

Nate Finch nate.finch at canonical.com
Thu Aug 22 19:00:07 UTC 2013


The signature of state.address is identical to instance.Address. It looks
like state.address only exists to convert to and from instance.Address for
use in state.machineDoc. My guess is that this is some duplication that
slipped in during the addressability changes.

Simply changing machineDoc to have []instance.Address instead of []address
(and removing the conversion code) compiles and tests fine. Any objections
to making this change? (interesting note, state.address has bson struct
tags on a couple fields, but the tests didn't complain when they were
missing... that's probably a hole in the tests. I'd probably move over the
bson tags to instance.Address, unless someone tells me they're not needed /
wanted).

-Nate
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20130822/e68366ed/attachment.html>


More information about the Juju-dev mailing list