Thoughts about the firewaller

[Gustavo Niemeyer]

On Thu, Oct 11, 2012 at 7:11 AM, roger peppe <roger.peppe at canonical.com> wrote:
>> 2) In the EnvironProvider.Validate methods of ec2 and dummy, transform
>> FwDefault into FwInstance
>
> I'm not sure about this. Why do we need FwDefault at all? The usual way
> of specifying a default value is by omitting the value from the configuration,
> and it seems like that might work OK here.

What you seem to argue for is that FwDefault has a different value,
rather than whether we need it or not. I'm fine with defining
FwDefault as "".

>> 3) Introduce EnvironProvider.OpenPort, ClosePort, and OpenedPorts.
>> These methods act on the global group at all times, and return an
>> error in case the provider does not support the global mode
>
> s/EnvironProvider/Environ/ presumably?

Indeed, thanks.


gustavo @ http://niemeyer.net