<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif">My apologies. <br></div><div class="gmail_default" style="font-family:verdana,sans-serif"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif">Apparently this patch uses a function "fwts_method_test_revision" that I have yet to submit. The function was included in a series of patches I prepared for ACPI 6.4 which is under review and not yet released.</div><div class="gmail_default" style="font-family:verdana,sans-serif"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif">As a result, this patch will cause compilation to fail and should be reverted in the fwts repository.<br></div><div class="gmail_default" style="font-family:verdana,sans-serif"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Dec 6, 2020 at 8:51 PM ivanhu <<a href="mailto:ivan.hu@canonical.com">ivan.hu@canonical.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
On 12/3/20 8:09 AM, Alex Hung wrote:<br>
> Signed-off-by: Alex Hung <<a href="mailto:alex.hung@canonical.com" target="_blank">alex.hung@canonical.com</a>><br>
> ---<br>
>  src/acpi/method/method.c | 22 ++++------------------<br>
>  1 file changed, 4 insertions(+), 18 deletions(-)<br>
> <br>
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c<br>
> index a881b503..f486d756 100644<br>
> --- a/src/acpi/method/method.c<br>
> +++ b/src/acpi/method/method.c<br>
> @@ -1866,7 +1866,7 @@ static void method_test_CPC_return(<br>
>               fwts_failed(fw, LOG_LEVEL_HIGH,<br>
>                       "Method_CPCBadRevision",<br>
>                       "_CPC's revision is incorrect, "<br>
> -                     "expecting 1 ,2 or 3, got 0x%" PRIx8 , revision);<br>
> +                     "expecting 1, 2 or 3, got 0x%" PRIx8 , revision);<br>
>  <br>
>               return;<br>
>       }<br>
> @@ -2786,14 +2786,8 @@ static void method_test_LPI_return(<br>
>                       }<br>
>  <br>
>                       if (i == 0) {<br>
> -                             if (obj->Package.Elements[i].Integer.Value != 0) {<br>
> -                                     fwts_failed(fw, LOG_LEVEL_HIGH,<br>
> -                                             "Method_LPIBadRevision",<br>
> -                                             "%s: Expected Revision to be 0, "<br>
> -                                             "got 0x%4.4" PRIx64 ".", name,<br>
> -                                             (uint64_t)obj->Package.Elements[i].Integer.Value);<br>
> +                             if (fwts_method_test_revision(fw, name, obj->Package.Elements[i].Integer.Value, 0) != FWTS_OK)<br>
>                                       failed = true;<br>
> -                             }<br>
>                       } else if (i == 2) {<br>
>                               if (obj->Package.Elements[i].Integer.Value != obj->Package.Count - 3) {<br>
>                                       fwts_failed(fw, LOG_LEVEL_HIGH,<br>
> @@ -4500,12 +4494,8 @@ static void method_test_FPS_return(<br>
>               return;<br>
>  <br>
>       if (obj->Package.Elements[0].Type == ACPI_TYPE_INTEGER) {<br>
> -             if (obj->Package.Elements[0].Integer.Value != 0) {<br>
> -                     fwts_failed(fw, LOG_LEVEL_MEDIUM,<br>
> -                             "Method_FPSBadRevision",<br>
> -                             "%s element 0 is not revision 0.", name);<br>
> +             if (fwts_method_test_revision(fw, name, obj->Package.Elements[0].Integer.Value, 0) != FWTS_OK)<br>
>                       failed = true;<br>
> -             }<br>
>       } else {<br>
>               fwts_failed(fw, LOG_LEVEL_MEDIUM,<br>
>                       "Method_FPSBadReturnType",<br>
> @@ -4713,12 +4703,8 @@ static void method_test_ART_return(<br>
>               return;<br>
>  <br>
>       if (obj->Package.Elements[0].Type == ACPI_TYPE_INTEGER) {<br>
> -             if (obj->Package.Elements[0].Integer.Value != 0) {<br>
> -                     fwts_failed(fw, LOG_LEVEL_MEDIUM,<br>
> -                             "Method_ARTBadRevision",<br>
> -                             "%s element 0 is not revision 0.", name);<br>
> +             if (fwts_method_test_revision(fw, name, obj->Package.Elements[0].Integer.Value, 0) != FWTS_OK)<br>
>                       failed = true;<br>
> -             }<br>
>       } else {<br>
>               fwts_failed(fw, LOG_LEVEL_MEDIUM,<br>
>                       "Method_ARTBadReturnType",<br>
> <br>
<br>
Acked-by: Ivan Hu <<a href="mailto:ivan.hu@canonical.com" target="_blank">ivan.hu@canonical.com</a>><br>
<br>
-- <br>
fwts-devel mailing list<br>
<a href="mailto:fwts-devel@lists.ubuntu.com" target="_blank">fwts-devel@lists.ubuntu.com</a><br>
Modify settings or unsubscribe at: <a href="https://lists.ubuntu.com/mailman/listinfo/fwts-devel" rel="noreferrer" target="_blank">https://lists.ubuntu.com/mailman/listinfo/fwts-devel</a><br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr">Cheers,<br>Alex Hung<br></div></div>