<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 01/17/2018 06:52 AM, Colin King
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20180116225208.4633-1-colin.king@canonical.com">
<pre wrap="">From: Colin Ian King <a class="moz-txt-link-rfc2396E" href="mailto:colin.king@canonical.com"><colin.king@canonical.com></a>
It appears that building with older versions of gcc with ACPI disabled
causes a linking problem as the symbol AcpiGbl_AbortLoopOnTimeout is
not available. The current workaround defines it as a unsigned char
type (same as ACPI's BOOLEAN) even though we never actually use it.
Signed-off-by: Colin Ian King <a class="moz-txt-link-rfc2396E" href="mailto:colin.king@canonical.com"><colin.king@canonical.com></a>
---
src/acpica/fwts_acpica.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/acpica/fwts_acpica.c b/src/acpica/fwts_acpica.c
index b7d2f861..89beecc0 100644
--- a/src/acpica/fwts_acpica.c
+++ b/src/acpica/fwts_acpica.c
@@ -1363,4 +1363,10 @@ VOID_FUNC(AeTableOverride)
VOID_FUNC(MpSaveGpioInfo)
VOID_FUNC(MpSaveSerialInfo)
+/*
+ * We need this otherwise gcc 4.5 ends up with a linker failure
+ * when building with ACPI disabled and I have no idea why.
+ */
+unsigned char AcpiGbl_AbortLoopOnTimeout = FALSE;
+
#endif
</pre>
</blockquote>
<br>
Acked-by: Ivan Hu <a class="moz-txt-link-rfc2396E"
href="mailto:ivan.hu@canonical.com"><ivan.hu@canonical.com></a>
</body>
</html>