[PATCH] acpi: acpipld: modify the test description to aviod misunderstanding
Ivan Hu
ivan.hu at canonical.com
Mon Jul 15 02:35:15 UTC 2024
BugLink: https://bugs.launchpad.net/fwts/+bug/2073023
This test does not verify that a connectable port has the _PLD method.
Instead, it ensures that a non-connectable port, identified by _UPC,
does not have the _PLD method.
failure such as,
acpipld: The ACPI method \_SB_.PCI0.XHC_.RHUB.HS06._PLD exists on the port claimed not connectable by the \_SB_.PCI0.XHC_.RHUB.HS06._UPC.
Change the test description to avoid misunderstanding. Use the following description:
"Check that the ACPI _PLD methods exist only on connectable ports.
Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
---
src/acpi/acpipld/acpipld.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/acpi/acpipld/acpipld.c b/src/acpi/acpipld/acpipld.c
index 638b36d7..df81ae0f 100644
--- a/src/acpi/acpipld/acpipld.c
+++ b/src/acpi/acpipld/acpipld.c
@@ -104,18 +104,18 @@ static int acpipld_test1(fwts_framework *fw)
}
if (!failed)
- fwts_passed(fw, "All _PLD methods exist on the port connectable.");
+ fwts_passed(fw, "All _PLD methods exist only on the port connectable.");
return FWTS_OK;
}
static fwts_framework_minor_test acpipld_tests[] = {
- { acpipld_test1, "Check the ACPI _PLD methods exist on the port connectable." },
+ { acpipld_test1, "Check the ACPI _PLD methods exist only on the port connectable." },
{ NULL, NULL }
};
static fwts_framework_ops acpipld_ops = {
- .description = "Check if the ACPI _PLD methods exist on the port connectable.",
+ .description = "Check if the ACPI _PLD methods exist only on the port connectable.",
.init = acpipld_init,
.deinit = acpipld_deinit,
.minor_tests = acpipld_tests
--
2.34.1
More information about the fwts-devel
mailing list