From ivan.hu at canonical.com Thu Aug 1 06:02:40 2024 From: ivan.hu at canonical.com (Ivan Hu) Date: Thu, 1 Aug 2024 14:02:40 +0800 Subject: [PATCH] configure.ac: fix the autoreconf AC_PROG_LIBTOOL warning Message-ID: <20240801060241.148396-1-ivan.hu@canonical.com> BugLink: https://bugs.launchpad.net/fwts/+bug/2075487 autoreconf -ivf results in: autoreconf: running: /usr/bin/autoconf --force configure.ac:9: warning: The macro `AC_PROG_LIBTOOL' is obsolete. configure.ac:9: You should run autoupdate. That apparently changed in 2008 per https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html. autoupdate suggests making this change to configure.ac: - AC_PROG_LIBTOOL + LT_INIT Signed-off-by: Ivan Hu --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ca2f54e2..ebf02193 100644 --- a/configure.ac +++ b/configure.ac @@ -6,7 +6,7 @@ AC_PROG_CC AC_PROG_LEX AC_PROG_YACC - AC_PROG_LIBTOOL + LT_INIT AC_C_INLINE AM_PROG_CC_C_O AC_CHECK_FUNCS([localtime_r]) -- 2.34.1 From ivan.hu at canonical.com Thu Aug 1 06:02:41 2024 From: ivan.hu at canonical.com (Ivan Hu) Date: Thu, 1 Aug 2024 14:02:41 +0800 Subject: [PATCH] configure.ac: fix the autoreconf AC_PROG_LEX warning In-Reply-To: <20240801060241.148396-1-ivan.hu@canonical.com> References: <20240801060241.148396-1-ivan.hu@canonical.com> Message-ID: <20240801060241.148396-2-ivan.hu@canonical.com> BugLink: https://bugs.launchpad.net/fwts/+bug/2075488 autoreconf -ivf results in autoreconf: running: /usr/bin/autoconf --force configure.ac:7: warning: AC_PROG_LEX without either yywrap or noyywrap is obsolete According to https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Particular-Programs.html that changed in 2020: Prior to Autoconf 2.70, AC_PROG_LEX did not take any arguments, and its behavior was different from either of the above possibilities: it would search for a library that defines yywrap, and would set LEXLIB to that library if it finds one. However, if a library that defines this function could not be found, LEXLIB would be left empty and LEX would not be reset. This behavior was due to a bug, but several packages came to depend on it, so AC_PROG_LEX still does this if neither the yywrap nor the noyywrap option is given. Usage of AC_PROG_LEX without choosing one of the yywrap or noyywrap options is deprecated. It is usually better to use noyywrap and define the yywrap function yourself, as this almost always renders the LEXLIB unnecessary. Signed-off-by: Ivan Hu --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ebf02193..fbf487c5 100644 --- a/configure.ac +++ b/configure.ac @@ -4,7 +4,7 @@ AC_CANONICAL_HOST AC_CONFIG_MACRO_DIR([m4]) AC_PROG_CC - AC_PROG_LEX + AC_PROG_LEX([noyywrap]) AC_PROG_YACC LT_INIT AC_C_INLINE -- 2.34.1