[PATCH] acpi: aest: modify the dumping raw data without noisy info

Ivan Hu ivan.hu at canonical.com
Tue Jun 13 01:54:41 UTC 2023


BugLink: https://bugs.launchpad.net/fwts/+bug/2023607

modify such as,

    SMMU-specific Data Subcomponent Reference: 0x44444444
    Vendor-specific data:
  0000: 12 23 34 45 56 67 78 89 9A AB BC CD DE EF FF 55 .#4EVgx........U
    Interface:

to simply hex dump,
    SMMU-specific Data Subcomponent Reference: 0x44444444
    Vendor-specific data:
      12 23 34 45 56 67 78 89 9A AB BC CD DE EF FF 55
    Interface:

Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
---
 src/acpi/aest/aest.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/acpi/aest/aest.c b/src/acpi/aest/aest.c
index 2768d505..61cf65a8 100644
--- a/src/acpi/aest/aest.c
+++ b/src/acpi/aest/aest.c
@@ -126,7 +126,6 @@ static int aest_test1(fwts_framework *fw)
 	node = (fwts_acpi_table_aest_node *)(table->data + sizeof(fwts_acpi_table_aest));
 	offset = sizeof(fwts_acpi_table_aest);
 	while (offset < table->length) {
-		char buffer[128];
 		fwts_acpi_table_aest_processor *processor = NULL;
 		fwts_acpi_table_aest_memory_controller *mem_controller = NULL;
 		fwts_acpi_table_aest_smmu *smmu = NULL;
@@ -184,11 +183,8 @@ static int aest_test1(fwts_framework *fw)
 				fwts_log_info_simp_int(fw, "    SMMU-specific Data Subcomponent Reference: ",
 					vendor_defined->unique_id);
 				fwts_log_info_verbatim(fw, "    Vendor-specific data:");
-				fwts_dump_raw_data(buffer, sizeof(buffer),
-					vendor_defined->vendor_specific_data,
-					0,
-					sizeof(vendor_defined->vendor_specific_data));
-				fwts_log_info_verbatim(fw, "%s", buffer);
+				fwts_hexdump_data_prefix_all(fw, vendor_defined->vendor_specific_data,
+					"      ", sizeof(vendor_defined->vendor_specific_data));
 				offset += sizeof(fwts_acpi_table_aest_vendor_defined);
 				break;
 			case FWTS_AEST_GIC:
-- 
2.34.1




More information about the fwts-devel mailing list