ACK: [PATCH 1/3] acpi/spcr: Update supported port types

[ivanhu]

Thanks!

Acked-by: Ivan Hu <ivan.hu at canonical.com>

On 7/12/23 16:37, arthur at aheymans.xyz wrote:
> From: Arthur Heymans <arthur at aheymans.xyz>
> 
> Newer types have been added.
> 
> Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
> ---
>   src/acpi/spcr/spcr.c | 47 +++++++++++++++++++++++++++++++++++++++++---
>   1 file changed, 44 insertions(+), 3 deletions(-)
> 
> diff --git a/src/acpi/spcr/spcr.c b/src/acpi/spcr/spcr.c
> index 1d865a3e..0f76d86a 100644
> --- a/src/acpi/spcr/spcr.c
> +++ b/src/acpi/spcr/spcr.c
> @@ -100,16 +100,42 @@ static int spcr_test1(fwts_framework *fw)
>   		str = "16550 compatible";
>   		break;
>   	case 0x01:
> -		str = "16450 compatible";
> +		str = "16550 subset compatible with DBGP Revision 1";
> +		break;
> +	case 0x02:
> +		str = "MAX311xE SPI UART";
>   		break;
>   	case 0x03:
>   		str = "ARM PL011 UART";
>   		break;
> -	case 0x02:
> -	case 0x04 ... 0x0c:
> +	case 0x04:
> +		str = "MSM8x60 (e.g. 8960)";
> +		break;
> +	case 0x05:
> +		str = "Nvidia 16550";
> +		break;
> +	case 0x06:
> +		str = "TI OMAP";
> +		break;
> +	case 0x07:
>   		str = "Reserved (Do not Use)";
>   		reserved = true;
>   		break;
> +	case 0x08:
> +		str = "APM88xxxx";
> +		break;
> +	case 0x09:
> +		str = "MSM8974";
> +		break;
> +	case 0x0a:
> +		str = "SAM5250";
> +		break;
> +	case 0x0b:
> +		str = "Intel USIF";
> +		break;
> +	case 0x0c:
> +		str = "i.MX6";
> +		break;
>   	case 0x0d:
>   		str = "(deprecated) ARM SBSA";
>   		break;
> @@ -122,6 +148,21 @@ static int spcr_test1(fwts_framework *fw)
>   	case 0x10:
>   		str = "BCM2835";
>   		break;
> +	case 0x11:
> +		str = "SDM845 with clock rate of 1.8432 MHz";
> +		break;
> +	case 0x12:
> +		str = "16550-compatible with parameters defined in Generic Address Structure";
> +		break;
> +	case 0x13:
> +		str = "SDM845 with clock rate of 7.372 MHz";
> +		break;
> +	case 0x14:
> +		str = "Intel LPSS";
> +		break;
> +	case 0x15:
> +		str = "RISC-V SBI console (any supported SBI mechanism)";
> +		break;
>   	default:
>   		str = "Reserved";
>   		reserved = true;