[PATCH 2/3] acpi/scpr: spcr->interrupt_type == 0 is valid

arthur at aheymans.xyz arthur at aheymans.xyz
Wed Jul 12 08:37:49 UTC 2023


From: Arthur Heymans <arthur at aheymans.xyz>

Interrupt type 0 means the described interface only supports polled
operation.

Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
 src/acpi/spcr/spcr.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/acpi/spcr/spcr.c b/src/acpi/spcr/spcr.c
index 0f76d86a..fe297c88 100644
--- a/src/acpi/spcr/spcr.c
+++ b/src/acpi/spcr/spcr.c
@@ -181,12 +181,6 @@ static int spcr_test1(fwts_framework *fw)
 	reserved1 = spcr->reserved1[0] + (spcr->reserved1[1] << 8) + (spcr->reserved1[2] << 16);
 	fwts_acpi_reserved_zero("SPCR", "Reserved1", reserved1, &passed);
 
-	if (spcr->interrupt_type == 0) {
-		passed = false;
-		fwts_failed(fw, LOG_LEVEL_HIGH,
-			"SPCRUnknownInterruptType",
-			"SPCR interrupt type field is zero, expecting support bits to be set");
-	}
 	if (spcr->interrupt_type & 0xf0) {
 		passed = false;
 		fwts_failed(fw, LOG_LEVEL_HIGH,
-- 
2.41.0




More information about the fwts-devel mailing list