fwts-22.03.00 build fix patch

[ivanhu]

This modification make build fail on my machine.


Cheers,

Ivan

On 5/12/22 00:43, orbea wrote:
> Hi,
>
> When building fwts with slibtool
> (https://dev.midipix.org/cross/slibtool) the build fail with undefined
> references. This is because the build system is using -lfoo linker
> flags for internal dependencies instead of using the libtool archive
> (.la) files instead. Additionally there are several instances of
> hardcoded pkg-config calls and linker flags in LDFLAGS rather than
> LIBADD and LDADD.
>
> I attached a patch that fixes the issues by doing a few things.
>
> * Removed hardcoded pkg-config calls and replaced them with
>   PKG_CHECK_MODULES as needed.
>
> * Clearly delimited LDFLAGS from LDADD and LIBADD. Build systems should
>   only add non-dependency linker flags to LDFLAGS while LDADD and
>   LIBADD should be for any required dependencies.
>
> * Removed any -lfoo linker flags for internal dependencies and added
>   them as .la files to link the fwts binary which now uses
>   -no-undefined. Using -lfoo linker flags should be only for external
>   dependencies and often results in undefined errors or the linker
>   flags entirely not found with slibtool. Slibtool is far more strict
>   about user error than GNU libtool which often silently hides such
>   issues.
>
> * Cleared out a few unneeded or redundant linker flags.
>
> Gentoo bug: https://bugs.gentoo.org/780372
>