ACK: [PATCH] uefi: securebootcert: make some function arguments const

ivanhu ivan.hu at canonical.com
Thu Sep 23 03:48:03 UTC 2021



On 9/22/21 6:32 PM, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> A couple of function arguments can be consified, cleans up
> cppcheck style warnings.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/uefi/securebootcert/securebootcert.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/src/uefi/securebootcert/securebootcert.c b/src/uefi/securebootcert/securebootcert.c
> index 7a0366ea..39ff1ebb 100644
> --- a/src/uefi/securebootcert/securebootcert.c
> +++ b/src/uefi/securebootcert/securebootcert.c
> @@ -263,7 +263,11 @@ static inline bool check_addr_overflow(
>          return (len > ~(uintptr_t)0 - (uintptr_t)var_data_addr);
>  }
>  
> -static bool check_sigdb_presence(uint8_t *var_data, size_t datalen, uint8_t *key, uint32_t key_len)
> +static bool check_sigdb_presence(
> +	uint8_t *var_data,
> +	const size_t datalen,
> +	const uint8_t *key,
> +	const uint32_t key_len)
>  {
>  	uint8_t *var_data_addr;
>  	EFI_SIGNATURE_LIST siglist;
> 

Acked-by: Ivan Hu <ivan.hu at canonical.com>



More information about the fwts-devel mailing list