ACK: [PATCH] lib: fwts_smbios: fix loading SMBIOS table from uefi

[ivanhu]

On 10/23/21 1:18 AM, Alex Hung wrote:
> From: G Edhaya Chandran <edhaya.chandran at arm.com>
> 
> Buglink: https://bugs.launchpad.net/bugs/1947956
> 
> In the case where SMBIOS table is loaded from
> /sys/firmware/dmi/tables/smbios_entry_point,
> the load fails due to a logical error in the if condition which is
> solved below:
> 
> The load fails with the below logs
> dmicheck: Could not find any SMBIOS Table Entry Points.
> dmicheck: Cannot find SMBIOS30 table entry.
> 
> Fixes: 8ce006f4ada ("lib: fwts_smbios: merge similar functions")
> Signed-off-by: Edhaya Chandran <edhaya.chandran at arm.com>
> Signed-off-by: Alex Hung <alex.hung at canonical.com
> ---
>  src/lib/src/fwts_smbios.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lib/src/fwts_smbios.c b/src/lib/src/fwts_smbios.c
> index 8da572e9..6402fad8 100644
> --- a/src/lib/src/fwts_smbios.c
> +++ b/src/lib/src/fwts_smbios.c
> @@ -91,7 +91,7 @@ static void *fwts_smbios_find_entry_uefi(
>  		}
>  
>  		if (fwts_load_file("/sys/firmware/dmi/tables/smbios_entry_point", entry, size) == FWTS_OK &&
> -		    strncmp((char*)entry, sm, strlen(sm))) {
> +		    !strncmp((char*)entry, sm, strlen(sm))) {
>  			fwts_log_info(fw, "%s entry loaded from /sys/firmware/dmi/tables/smbios_entry_point\n", smbios);
>  			*type  = FWTS_SMBIOS;
>  			return addr;
> 


Acked-by: Ivan Hu <ivan.hu at canonical.com>