ACK: [PATCH] acpi: s3: ensure duration is initialized

Alex Hung alex.hung at canonical.com
Tue Mar 30 21:44:45 UTC 2021


On 2021-03-30 4:51 a.m., Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Pedantic static analyzers complain that variable duration is not
> initialized.  Ensure it really is by setting it to zero.
> 
> Addresses-Coverity: ("Uninitialized scalar variable").
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/acpi/s3/s3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/acpi/s3/s3.c b/src/acpi/s3/s3.c
> index 9cc94a17..fd47c861 100644
> --- a/src/acpi/s3/s3.c
> +++ b/src/acpi/s3/s3.c
> @@ -236,7 +236,7 @@ static int s3_do_suspend_resume(fwts_framework *fw,
>  {
>  	fwts_hwinfo hwinfo1, hwinfo2;
>  	int status;
> -	int duration;
> +	int duration = 0;
>  	int differences;
>  	int rc = FWTS_OK;
>  	char *command = NULL;
> 


Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list