ACK: [PATCH][V2] acpi: method: remove redundant continue statements

Alex Hung alex.hung at canonical.com
Tue Mar 30 21:44:32 UTC 2021


On 2021-03-30 5:01 a.m., Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> The continue statement at the end of a for-loop is redundant. Remove
> it to silence pedantic static analysis warnings.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
> 
> V2: Fix two more of these issues
> 
> ---
>  src/acpi/method/method.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c
> index f5253de9..763c3252 100644
> --- a/src/acpi/method/method.c
> +++ b/src/acpi/method/method.c
> @@ -3620,10 +3620,8 @@ static void method_test_FPS_return(
>  				elements_ok = false;
>  		}
>  
> -		if (!elements_ok) {
> +		if (!elements_ok)
>  			failed = true;
> -			continue;
> -		}
>  	}
>  
>  	if (!failed)
> @@ -3821,10 +3819,8 @@ static void method_test_ART_return(
>  
>  		}
>  
> -		if (!elements_ok) {
> +		if (!elements_ok)
>  			failed = true;
> -			continue;
> -		}
>  	}
>  
>  	if (!failed)
> @@ -3884,10 +3880,8 @@ static void method_test_TRT_return(
>  				elements_ok = false;
>  		}
>  
> -		if (!elements_ok) {
> +		if (!elements_ok)
>  			failed = true;
> -			continue;
> -		}
>  	}
>  
>  	if (!failed)
> 


Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list