ACK with comments: [PATCH 5/5] Debian: add Rules-Requires-Root field to control file

Alex Hung alex.hung at canonical.com
Sat Jun 19 01:41:00 UTC 2021


On Fri, Jun 18, 2021 at 4:06 PM Colin Ian King <colin.king at canonical.com>
wrote:

> On 18/06/2021 21:02, Alex Hung wrote:
> > On 2021-06-18 6:57 a.m., Colin King wrote:
> >> From: Colin Ian King <colin.king at canonical.com>
> >>
> >> Clean up lintian warning, add Homepage
>
> bah, typo should be add Rules-Requires-root. Can that be reworked before
> applying it?
>

Sure I can do that.

>
> >
> > There is no Homepage in the patch (but in PATCH 4/5). Is this a typo?
> >
> > I can fix this when applying though.
> >
> >>
> >> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> >> ---
> >>  debian/control | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/debian/control b/debian/control
> >> index 29d3c40f..6f05a93b 100644
> >> --- a/debian/control
> >> +++ b/debian/control
> >> @@ -1,6 +1,7 @@
> >>  Source: fwts
> >>  Section: devel
> >>  Priority: optional
> >> +Rules-Requires-Root: no
> >>  Maintainer: Firmware Testing Team <fwts-devel at lists.ubuntu.com>
> >>  Uploaders: Colin King <colin.king at ubuntu.com>, Alex Hung <
> alex.hung at canonical.com>, Ivan Hu <ivan.hu at canonical.com>
> >>  Standards-Version: 3.9.7
> >>
> >
> > Acked-by: Alex Hung <alex.hung at canonical.com>
> >
>
>

-- 
Cheers,
Alex Hung
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20210618/a3a496a7/attachment.html>


More information about the fwts-devel mailing list