ACK: [PATCH] fwts_acpi_tables: skip FACS warning for reduced hardware

[ivanhu]

On 6/29/21 8:50 AM, Alex Hung wrote:
> "This structure is optional if and only if the
> HARDWARE_REDUCED_ACPI flag in the FADT is set."
> 
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
>  src/lib/src/fwts_acpi_tables.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index b8b710bc..b08cbdfd 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -1028,8 +1028,11 @@ static int fwts_acpi_load_tables_fixup(fwts_framework *fw)
>  		uint64_t facs_addr;
>  		fwts_acpi_table_facs *facs = NULL;
>  
> -		/* This is most unexpected, so warn about it */
> -		fwts_log_warning(fw, "No FACS found, fwts has faked one instead.");
> +		if (fwts_acpi_is_reduced_hardware(fw))	/* FACS is optional on reduced hardware */
> +			fwts_log_info(fw, "No FACS found, fwts has faked one instead.");
> +		else	/* This is most unexpected, so warn about it */
> +			fwts_log_warning(fw, "No FACS found, fwts has faked one instead.");
> +
>  		if ((facs = fwts_low_calloc(1, size)) == NULL) {
>  			fwts_log_error(fw, "Cannot allocate fake FACS.");
>  			return FWTS_ERROR;
> 

Acked-by: Ivan Hu <ivan.hu at canonical.com>