Re: Build error: fwts_acpi_tables.c "‘strncat’ specified bound 2 equals source length"

[Alex Hung]

Hi Rebecca,

I was able to reproduce the errors and the attached could fix the problem
on RPI4.

Please give it a try. If it fixes the problem for you I will submit it for
patch reviews.

Cheers,
Alex Hung

On Wed, Jan 13, 2021 at 1:15 AM Alex Hung <alex.hung at canonical.com> wrote:

> I tried building it on Ubuntu 20.04 + gcc (Ubuntu/Linaro 8.4.0-3ubuntu2)
> 8.4.0 on aarch64 (raspberry pi 4) and cannot duplicate it.
>
> I don't debian + gcc 8.3.0 on aarch64 at the moment. You may want to
> revert the problematic commit first before this is fixed.
>
> On Wed, Jan 13, 2021 at 12:33 AM Rebecca Cran <rebecca at nuviainc.com>
> wrote:
>
>> I'm getting a build error on Debian aarch64, with gcc 8.3.0 and the
>> latest master (b8b673c3f232efcd15ad9693386b3dd195d1dfa1):
>>
>> fwts_acpi_tables.c: In function ‘fwts_acpi_space_id_check’:
>> fwts_acpi_tables.c:1683:4: error: ‘strncat’ specified bound 2 equals
>> source length [-Werror=stringop-overflow=]
>>      strncat(must_be_id, ", ", 2);
>>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> fwts_acpi_tables.c:1685:4: error: ‘strncat’ specified bound 4 equals
>> source length [-Werror=stringop-overflow=]
>>      strncat(must_be_id, " or ", 4);
>>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>>
>> --
>> Rebecca Cran
>>
>> --
>> fwts-devel mailing list
>> fwts-devel at lists.ubuntu.com
>> Modify settings or unsubscribe at:
>> https://lists.ubuntu.com/mailman/listinfo/fwts-devel
>>
>
>
> --
> Cheers,
> Alex Hung
>


-- 
Cheers,
Alex Hung
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20210114/daddbb73/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lib-fix-compile-error-for-debian-gcc-8.3.patch
Type: text/x-patch
Size: 987 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/fwts-devel/attachments/20210114/daddbb73/attachment-0001.bin>