ACK: [PATCH 2/2] fwts-test: sync up with fwts_log_info_simp_int changes
Colin Ian King
colin.king at canonical.com
Wed Jan 13 09:51:16 UTC 2021
On 11/01/2021 18:35, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung at canonical.com>
> ---
> fwts-test/hest-0001/hest-0001.log | 8 ++++----
> fwts-test/hest-0001/hest-0002.log | 8 ++++----
> fwts-test/hmat-0001/hmat-0001.log | 2 +-
> fwts-test/hmat-0001/hmat-0002.log | 2 +-
> fwts-test/iort-0001/iort-0001.log | 8 ++++----
> fwts-test/iort-0001/iort-0002.log | 8 ++++----
> fwts-test/mpst-0001/mpst-0001.log | 8 ++++----
> fwts-test/mpst-0001/mpst-0002.log | 8 ++++----
> fwts-test/pcct-0001/pcct-0001.log | 6 +++---
> fwts-test/pcct-0001/pcct-0002.log | 6 +++---
> fwts-test/pdtt-0001/pdtt-0001.log | 2 +-
> fwts-test/pdtt-0001/pdtt-0002.log | 2 +-
> fwts-test/slit-0001/slit-0001.log | 2 +-
> fwts-test/slit-0001/slit-0002.log | 2 +-
> 14 files changed, 36 insertions(+), 36 deletions(-)
>
> diff --git a/fwts-test/hest-0001/hest-0001.log b/fwts-test/hest-0001/hest-0001.log
> index c87a1bb8..e0d7d394 100644
> --- a/fwts-test/hest-0001/hest-0001.log
> +++ b/fwts-test/hest-0001/hest-0001.log
> @@ -2,10 +2,10 @@ hest hest: HEST Hardware Error Source Table test.
> hest ----------------------------------------------------------
> hest Test 1 of 1: HEST Hardware Error Source Table test.
> hest HEST Hardware Error Source Table test
> -hest Error Source Count: 0x03
> +hest Error Source Count: 0x00000003
> hest
> hest HEST PCI Express Root Port AER:
> -hest Type: 0x06
> +hest Type: 0x0006
> hest Source ID: 0x0006
> hest Reserved: 0x0000
> hest Flags: 0x02
> @@ -24,7 +24,7 @@ hest Advanced Capabilities: 0x00000000
> hest Root Error Command: 0x00000006
> hest
> hest HEST PCI Express Device AER:
> -hest Type: 0x07
> +hest Type: 0x0007
> hest Source ID: 0x0007
> hest Reserved: 0x0000
> hest Flags: 0x02
> @@ -41,7 +41,7 @@ hest Correctable Error Mask: 0x000011c1
> hest Advanced Capabilities: 0x00000000
> hest
> hest HEST PCI Express Bridge AER:
> -hest Type: 0x08
> +hest Type: 0x0008
> hest Source ID: 0x0008
> hest Reserved: 0x0000
> hest Flags: 0x02
> diff --git a/fwts-test/hest-0001/hest-0002.log b/fwts-test/hest-0001/hest-0002.log
> index 88aa45da..8c57379b 100644
> --- a/fwts-test/hest-0001/hest-0002.log
> +++ b/fwts-test/hest-0001/hest-0002.log
> @@ -2,10 +2,10 @@ hest hest: HEST Hardware Error Source Table test.
> hest ----------------------------------------------------------
> hest Test 1 of 1: HEST Hardware Error Source Table test.
> hest HEST Hardware Error Source Table test
> -hest Error Source Count: 0x03
> +hest Error Source Count: 0x00000003
> hest
> hest HEST PCI Express Root Port AER:
> -hest Type: 0x06
> +hest Type: 0x0006
> hest Source ID: 0x0006
> hest Reserved: 0x0000
> hest Flags: 0x07
> @@ -27,7 +27,7 @@ hest FAILED [HIGH] HESTReservedBitsNonZero: Test 1, HEST PCI
> hest Express Root Port Flags Bits [7..2] must be zero, got 0x07
> hest instead
> hest HEST PCI Express Device AER:
> -hest Type: 0x07
> +hest Type: 0x0007
> hest Source ID: 0x00ff
> hest Reserved: 0x0000
> hest Flags: 0x09
> @@ -50,7 +50,7 @@ hest FAILED [HIGH] HESTInvalidRecordsToPreallocate: Test 1,
> hest HEST PCI Express Device Number of Records to Preallocate
> hest is 0x0 and must be more than zero.
> hest HEST PCI Express Bridge AER:
> -hest Type: 0x08
> +hest Type: 0x0008
> hest Source ID: 0x0008
> hest Reserved: 0x0000
> hest Flags: 0x0f
> diff --git a/fwts-test/hmat-0001/hmat-0001.log b/fwts-test/hmat-0001/hmat-0001.log
> index cf8c6513..c68b2671 100644
> --- a/fwts-test/hmat-0001/hmat-0001.log
> +++ b/fwts-test/hmat-0001/hmat-0001.log
> @@ -2,7 +2,7 @@ hmat hmat: HMAT Heterogeneous Memory Attribute Table test.
> hmat ----------------------------------------------------------
> hmat Test 1 of 1: Validate HMAT table.
> hmat HMAT Heterogeneous Memory Attribute Table:
> -hmat Reserved: 0x00
> +hmat Reserved: 0x00000000
> hmat Memory Proximity Domain Attributes (Type 0):
> hmat Type: 0x0000
> hmat Reserved: 0x0000
> diff --git a/fwts-test/hmat-0001/hmat-0002.log b/fwts-test/hmat-0001/hmat-0002.log
> index b42006c7..567b069c 100644
> --- a/fwts-test/hmat-0001/hmat-0002.log
> +++ b/fwts-test/hmat-0001/hmat-0002.log
> @@ -2,7 +2,7 @@ hmat hmat: HMAT Heterogeneous Memory Attribute Table test.
> hmat ----------------------------------------------------------
> hmat Test 1 of 1: Validate HMAT table.
> hmat HMAT Heterogeneous Memory Attribute Table:
> -hmat Reserved: 0x00
> +hmat Reserved: 0x00000000
> hmat Memory Proximity Domain Attributes (Type 0):
> hmat Type: 0x0000
> hmat Reserved: 0x0001
> diff --git a/fwts-test/iort-0001/iort-0001.log b/fwts-test/iort-0001/iort-0001.log
> index e8bda77b..9ad7ff36 100644
> --- a/fwts-test/iort-0001/iort-0001.log
> +++ b/fwts-test/iort-0001/iort-0001.log
> @@ -2,9 +2,9 @@ iort iort: IORT IO Remapping Table test.
> iort ----------------------------------------------------------
> iort Test 1 of 1: IORT IO Remapping Table test.
> iort IORT IO Remapping Table test
> -iort Number of IORT Nodes: 0x0004
> -iort IORT Node Array Offset: 0x0030
> -iort Reserved: 0x0000
> +iort Number of IORT Nodes: 0x00000004
> +iort IORT Node Array Offset: 0x00000030
> +iort Reserved: 0x00000000
> iort
> iort IORT ITS Group Node:
> iort Type: 0x00
> @@ -55,7 +55,7 @@ iort Reference to ID Array: 0x00000020
> iort Cache Coherent Attribute: 0x00000001
> iort Allocation Hints: 0x0e
> iort Reserved: 0x0000
> -iort Memory Access Flags 0x0003
> +iort Memory Access Flags 0x03
> iort ATS Attribute: 0x00000001
> iort PCI Segment Number: 0xc0bbeeff
> iort ID Mapping 0
> diff --git a/fwts-test/iort-0001/iort-0002.log b/fwts-test/iort-0001/iort-0002.log
> index 014b4648..54c83f9b 100644
> --- a/fwts-test/iort-0001/iort-0002.log
> +++ b/fwts-test/iort-0001/iort-0002.log
> @@ -2,9 +2,9 @@ iort iort: IORT IO Remapping Table test.
> iort ----------------------------------------------------------
> iort Test 1 of 1: IORT IO Remapping Table test.
> iort IORT IO Remapping Table test
> -iort Number of IORT Nodes: 0x0005
> -iort IORT Node Array Offset: 0x0030
> -iort Reserved: 0x0000
> +iort Number of IORT Nodes: 0x00000005
> +iort IORT Node Array Offset: 0x00000030
> +iort Reserved: 0x00000000
> iort
> iort IORT ITS Group Node:
> iort Type: 0x00
> @@ -89,7 +89,7 @@ iort Reference to ID Array: 0x00000020
> iort Cache Coherent Attribute: 0x000000d1
> iort Allocation Hints: 0xfe
> iort Reserved: 0x8000
> -iort Memory Access Flags 0x0003
> +iort Memory Access Flags 0x03
> iort ATS Attribute: 0x00000003
> iort PCI Segment Number: 0xc0bbeeff
> iort ID Mapping 0
> diff --git a/fwts-test/mpst-0001/mpst-0001.log b/fwts-test/mpst-0001/mpst-0001.log
> index 9ebd0d85..a280b442 100644
> --- a/fwts-test/mpst-0001/mpst-0001.log
> +++ b/fwts-test/mpst-0001/mpst-0001.log
> @@ -19,9 +19,9 @@ mpst Power State Value: 0x01
> mpst Power State Information Index: 0x02
> mpst Power State Value: 0x03
> mpst Power State Information Index: 0x04
> -mpst Physical Component Id: 0x00
> -mpst Physical Component Id: 0x01
> -mpst Physical Component Id: 0x02
> +mpst Physical Component Id: 0x0000
> +mpst Physical Component Id: 0x0001
> +mpst Physical Component Id: 0x0002
> mpst MPST Power Node:
> mpst Flags: 0x00
> mpst Reserved: 0x00
> @@ -33,7 +33,7 @@ mpst Number of Power States: 0x00000001
> mpst Number of Physical Components: 0x00000001
> mpst Power State Value: 0x05
> mpst Power State Information Index: 0x06
> -mpst Physical Component Id: 0x03
> +mpst Physical Component Id: 0x0003
> mpst Memory Characteristics Count: 0x0002
> mpst Reserved: 0x0000
> mpst MPST Power Characteristics:
> diff --git a/fwts-test/mpst-0001/mpst-0002.log b/fwts-test/mpst-0001/mpst-0002.log
> index 37b216b7..2ff7555f 100644
> --- a/fwts-test/mpst-0001/mpst-0002.log
> +++ b/fwts-test/mpst-0001/mpst-0002.log
> @@ -27,9 +27,9 @@ mpst Power State Value: 0x01
> mpst Power State Information Index: 0x02
> mpst Power State Value: 0x03
> mpst Power State Information Index: 0x04
> -mpst Physical Component Id: 0x00
> -mpst Physical Component Id: 0x01
> -mpst Physical Component Id: 0x02
> +mpst Physical Component Id: 0x0000
> +mpst Physical Component Id: 0x0001
> +mpst Physical Component Id: 0x0002
> mpst MPST Power Node:
> mpst Flags: 0x00
> mpst Reserved: 0x05
> @@ -45,7 +45,7 @@ mpst FAILED [HIGH] MPSTBadPowerNodeLength: Test 1, MPST Power
> mpst Node Length should be 0x00000024, got 0x00000124 instead
> mpst Power State Value: 0x05
> mpst Power State Information Index: 0x06
> -mpst Physical Component Id: 0x03
> +mpst Physical Component Id: 0x0003
> mpst Memory Characteristics Count: 0x0002
> mpst Reserved: 0x0006
> mpst FAILED [MEDIUM] MPSTReservedNonZero: Test 1, MPST Reserved
> diff --git a/fwts-test/pcct-0001/pcct-0001.log b/fwts-test/pcct-0001/pcct-0001.log
> index 8703a987..e7e3aced 100644
> --- a/fwts-test/pcct-0001/pcct-0001.log
> +++ b/fwts-test/pcct-0001/pcct-0001.log
> @@ -21,7 +21,7 @@ pcct Doorbell Preserve: 0x4444444444444444
> pcct Doorbell Write: 0x5555555555555555
> pcct Nominal Latency: 0x66666666
> pcct Max Periodic Access Rate: 0x77777777
> -pcct Min Request Turnaround Time: 0x00008888
> +pcct Min Request Turnaround Time: 0x8888
> pcct
> pcct PCC Subspace Structure:
> pcct Type: 0x01
> @@ -41,7 +41,7 @@ pcct Doorbell Preserve: 0x4444444444444444
> pcct Doorbell Write: 0x5555555555555555
> pcct Nominal Latency: 0x66666666
> pcct Max Periodic Access Rate: 0x77777777
> -pcct Min Request Turnaround Time: 0x00008888
> +pcct Min Request Turnaround Time: 0x8888
> pcct
> pcct PCC Subspace Structure:
> pcct Type: 0x02
> @@ -61,7 +61,7 @@ pcct Doorbell Preserve: 0x4444444444444444
> pcct Doorbell Write: 0x5555555555555555
> pcct Nominal Latency: 0x66666666
> pcct Max Periodic Access Rate: 0x77777777
> -pcct Min Request Turnaround Time: 0x00008888
> +pcct Min Request Turnaround Time: 0x8888
> pcct Platform Interrupt Ack Register:
> pcct Address Space ID 0x01
> pcct Register Bit Width 0x32
> diff --git a/fwts-test/pcct-0001/pcct-0002.log b/fwts-test/pcct-0001/pcct-0002.log
> index a7630e5d..b7ef892c 100644
> --- a/fwts-test/pcct-0001/pcct-0002.log
> +++ b/fwts-test/pcct-0001/pcct-0002.log
> @@ -21,7 +21,7 @@ pcct Doorbell Preserve: 0x4444444444444444
> pcct Doorbell Write: 0x5555555555555555
> pcct Nominal Latency: 0x66666666
> pcct Max Periodic Access Rate: 0x77777777
> -pcct Min Request Turnaround Time: 0x00008888
> +pcct Min Request Turnaround Time: 0x8888
> pcct FAILED [HIGH] PCCTBadAddressSpaceId: Test 1, PCCT Subspace
> pcct Type 0 Space ID must be one of System Memory (0x0) or
> pcct System I/O (0x1), got PCI Configuration (0x2) instead.
> @@ -48,7 +48,7 @@ pcct Doorbell Preserve: 0x4444444444444444
> pcct Doorbell Write: 0x5555555555555555
> pcct Nominal Latency: 0x66666666
> pcct Max Periodic Access Rate: 0x77777777
> -pcct Min Request Turnaround Time: 0x00008888
> +pcct Min Request Turnaround Time: 0x8888
> pcct
> pcct PCC Subspace Structure:
> pcct Type: 0x02
> @@ -72,7 +72,7 @@ pcct Doorbell Preserve: 0x4444444444444444
> pcct Doorbell Write: 0x5555555555555555
> pcct Nominal Latency: 0x66666666
> pcct Max Periodic Access Rate: 0x77777777
> -pcct Min Request Turnaround Time: 0x00008888
> +pcct Min Request Turnaround Time: 0x8888
> pcct Platform Interrupt Ack Register:
> pcct Address Space ID 0x03
> pcct Register Bit Width 0x32
> diff --git a/fwts-test/pdtt-0001/pdtt-0001.log b/fwts-test/pdtt-0001/pdtt-0001.log
> index 555a015c..fe059f2c 100644
> --- a/fwts-test/pdtt-0001/pdtt-0001.log
> +++ b/fwts-test/pdtt-0001/pdtt-0001.log
> @@ -4,7 +4,7 @@ pdtt Test 1 of 1: Validate PDTT table.
> pdtt PDTT Platform Debug Trigger Table:
> pdtt Trigger Count: 0x04
> pdtt Reserved[3]: 0x000000
> -pdtt Trigger ID Array Offset: 0x2c
> +pdtt Trigger ID Array Offset: 0x0000002c
> pdtt Platform Communication Channel IDs
> pdtt Sub channel ID: 0xaa
> pdtt Flags: 0x03
> diff --git a/fwts-test/pdtt-0001/pdtt-0002.log b/fwts-test/pdtt-0001/pdtt-0002.log
> index c6bb2f06..eff8e70a 100644
> --- a/fwts-test/pdtt-0001/pdtt-0002.log
> +++ b/fwts-test/pdtt-0001/pdtt-0002.log
> @@ -4,7 +4,7 @@ pdtt Test 1 of 1: Validate PDTT table.
> pdtt PDTT Platform Debug Trigger Table:
> pdtt Trigger Count: 0x04
> pdtt Reserved[3]: 0x030201
> -pdtt Trigger ID Array Offset: 0x2c
> +pdtt Trigger ID Array Offset: 0x0000002c
> pdtt FAILED [MEDIUM] PDTTReservedNonZero: Test 1, PDTT Reserved
> pdtt field must be zero, got 0x00030201 instead
> pdtt Platform Communication Channel IDs
> diff --git a/fwts-test/slit-0001/slit-0001.log b/fwts-test/slit-0001/slit-0001.log
> index 5dc9a791..2bbebc4d 100644
> --- a/fwts-test/slit-0001/slit-0001.log
> +++ b/fwts-test/slit-0001/slit-0001.log
> @@ -3,7 +3,7 @@ slit ----------------------------------------------------------
> slit Test 1 of 1: SLIT System Locality Distance Information
> slit test.
> slit SLIT System Locality Distance Information Table:
> -slit Number of Localities: 0x8
> +slit Number of Localities: 0x0000000000000008
> slit PASSED: Test 1, No issues found in SLIT table.
> slit
> slit ==========================================================
> diff --git a/fwts-test/slit-0001/slit-0002.log b/fwts-test/slit-0001/slit-0002.log
> index fadc2f95..c6309867 100644
> --- a/fwts-test/slit-0001/slit-0002.log
> +++ b/fwts-test/slit-0001/slit-0002.log
> @@ -3,7 +3,7 @@ slit ----------------------------------------------------------
> slit Test 1 of 1: SLIT System Locality Distance Information
> slit test.
> slit SLIT System Locality Distance Information Table:
> -slit Number of Localities: 0x8
> +slit Number of Localities: 0x0000000000000008
> slit FAILED [HIGH] SLITBadCornerEntry: Test 1, SLIT Entry[0][0]
> slit is 0xb, expecting value 0x0a.
> slit FAILED [HIGH] SLITBadCornerEntry: Test 1, SLIT Entry[7][7]
>
Acked-by: Colin Ian King <colin.king at canonical.com>
More information about the fwts-devel
mailing list