ACK: [PATCH 1/1] acpi: lib: correct revision of the fake XSDT table

[Alex Hung]

On 2021-01-04 10:11 p.m., Nhi Pham wrote:
> According to ACPI 6.3 specification, section 5.2.8 Extended System
> Description Table (XSDT), the 'Revision' field of XSDT table is 1,
> not 2. So, the current fake XSDT table generated by fwts causes the test
> case ACPITableBadRevision failed due to the revision is not matched with
> ACPI 6.3.
> 
> This patch changes the revision of the fake XSDT table from 2 to 1 as
> this revision is compatible both with ACPI 6.3 and older versions.

Thanks for the fix.

> 
> Signed-off-by: Nhi Pham <nhi at os.amperecomputing.com>
> ---
>  src/lib/src/fwts_acpi_tables.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index af4736b370a9..171b37d420ed 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -1143,7 +1143,7 @@ static int fwts_acpi_load_tables_fixup(fwts_framework *fw)
>  
>  		(void)memcpy(xsdt->header.signature, "XSDT", 4);
>  		xsdt->header.length = size;
> -		xsdt->header.revision = 2;
> +		xsdt->header.revision = 1;
>  		(void)memcpy(xsdt->header.oem_id, "FWTSID", 6);
>  		(void)memcpy(xsdt->header.oem_tbl_id, oem_tbl_id, 8);
>  		xsdt->header.oem_revision = 1;
> 


Just for information - I don't think the revision is going to be changed
in ACPI 6.4 either.

Acked-by: Alex Hung <alex.hung at canonical.com>