ACK: [PATCH] s4: clean up pedantic static analysis warnings

Alex Hung alex.hung at canonical.com
Sat Dec 4 02:03:37 UTC 2021


On 2021-11-30 1:20 a.m., Ivan Hu wrote:
> Static analysis is warning Unchecked return value (CHECKED_RETURN) by
> call fwts_set. Clean up this warning with adding (void).
> 
> Signed-off-by: Ivan Hu <ivan.hu at canonical.com>
> ---
>  src/acpi/s4/s4.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/acpi/s4/s4.c b/src/acpi/s4/s4.c
> index f92ecc2d..fbd968c8 100644
> --- a/src/acpi/s4/s4.c
> +++ b/src/acpi/s4/s4.c
> @@ -413,7 +413,7 @@ static int s4_test_multiple(fwts_framework *fw)
>  
>  					fwts_log_info(fw, "Setting tracing buffer size to 1K for subsequent tests.");
>  
> -					fwts_set("1", FWTS_TRACING_BUFFER_SIZE);
> +					(void)fwts_set("1", FWTS_TRACING_BUFFER_SIZE);
>  					failed_alloc_image = 0;
>  
>  					if (s4_hibernate(fw,
> @@ -463,7 +463,7 @@ static int s4_test_multiple(fwts_framework *fw)
>  
>  		/* Restore tracking buffer size */
>  		snprintf(tmp, sizeof(tmp), "%d", tracing_buffer_size);
> -		fwts_set(tmp, FWTS_TRACING_BUFFER_SIZE);
> +		(void)fwts_set(tmp, FWTS_TRACING_BUFFER_SIZE);
>  	}
>  
>  	if (klog_errors > 0)
> 


Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list