ACK: [PATCH] fwts_arch: rename helper __fwts_arch_get_arch to fwts_arch_get_arch_by_name

Alex Hung alex.hung at canonical.com
Sun Apr 11 20:54:03 UTC 2021


On 2021-04-11 7:19 a.m., Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Rename the helper function __fwts_arch_get_arch to remove __ prefix. The
> prefix is normally reserved for new types or keywords so don't use it
> where possible.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/lib/src/fwts_arch.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/lib/src/fwts_arch.c b/src/lib/src/fwts_arch.c
> index 2b015bf3..d60f25a6 100644
> --- a/src/lib/src/fwts_arch.c
> +++ b/src/lib/src/fwts_arch.c
> @@ -43,7 +43,7 @@ static const struct fwts_arch_info arch_name[] = {
>  
>  static char *arch_names;
>  
> -static fwts_architecture __fwts_arch_get_arch(const char *name)
> +static fwts_architecture fwts_arch_get_arch_by_name(const char *name)
>  {
>  	const struct fwts_arch_info *ptr;
>  
> @@ -61,12 +61,12 @@ fwts_architecture fwts_arch_get_host(void)
>  	if (uname(&buf))
>  		return FWTS_ARCH_OTHER;
>  
> -	return __fwts_arch_get_arch(buf.machine);
> +	return fwts_arch_get_arch_by_name(buf.machine);
>  }
>  
>  fwts_architecture fwts_arch_get_arch(const char *name)
>  {
> -	return __fwts_arch_get_arch(name);
> +	return fwts_arch_get_arch_by_name(name);
>  }
>  
>  char *fwts_arch_names(void)
> 


Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list