ACK: [PATCH] fwts_devicetree.h: clean up #define indents, constify function arg

Alex Hung alex.hung at canonical.com
Sun Apr 11 20:52:47 UTC 2021


On 2021-04-10 5:16 p.m., Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
> 
> Minor clean up, align #define definitions and constify a function
> argument.
> 
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
> ---
>  src/lib/include/fwts_devicetree.h | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/src/lib/include/fwts_devicetree.h b/src/lib/include/fwts_devicetree.h
> index 7320beb7..553198b1 100644
> --- a/src/lib/include/fwts_devicetree.h
> +++ b/src/lib/include/fwts_devicetree.h
> @@ -28,16 +28,16 @@
>  #define FWTS_HAS_DEVICETREE 0
>  #endif
>  
> -#define DT_FS_PATH "/sys/firmware/devicetree/base"
> -#define DT_LINUX_PCI_DEVICES "/sys/bus/pci/devices"
> -#define DT_PROPERTY_OPAL_PCI_SLOT "ibm,slot-label"
> -#define DT_PROPERTY_OPAL_SLOT_LOC "ibm,slot-location-code"
> -#define DT_PROPERTY_OPAL_PART_NUM "part-number"
> -#define DT_PROPERTY_OPAL_SERIAL_NUM "serial-number"
> +#define DT_FS_PATH 			 "/sys/firmware/devicetree/base"
> +#define DT_LINUX_PCI_DEVICES		 "/sys/bus/pci/devices"
> +#define DT_PROPERTY_OPAL_PCI_SLOT	 "ibm,slot-label"
> +#define DT_PROPERTY_OPAL_SLOT_LOC	 "ibm,slot-location-code"
> +#define DT_PROPERTY_OPAL_PART_NUM	 "part-number"
> +#define DT_PROPERTY_OPAL_SERIAL_NUM	 "serial-number"
>  #define DT_PROPERTY_OPAL_MANUFACTURER_ID "manufacturer-id"
> -#define DT_PROPERTY_OPAL_STATUS "status"
> -#define DT_PROPERTY_OPAL_VENDOR "vendor"
> -#define DT_PROPERTY_OPAL_BOARD_INFO "board-info"
> +#define DT_PROPERTY_OPAL_STATUS		 "status"
> +#define DT_PROPERTY_OPAL_VENDOR		 "vendor"
> +#define DT_PROPERTY_OPAL_BOARD_INFO	 "board-info"
>  
>  #if FWTS_HAS_DEVICETREE
>  
> @@ -139,7 +139,7 @@ bool check_status_property_okay(fwts_framework *fw,
>  	const char *my_path, const char *my_prop_string, const char *property);
>  
>  int check_property_printable(fwts_framework *fw,
> -	const char *name, const char *buf, size_t len);
> +	const char *name, const char *buf, const size_t len);
>  
>  char *hidewhitespace(char *name);
>  
> 

Acked-by: Alex Hung <alex.hung at canonical.com>



More information about the fwts-devel mailing list