ACK: [PATCH 2/2] fwts-test: sync up with sdev changes
Colin Ian King
colin.king at canonical.com
Wed Apr 7 09:17:03 UTC 2021
On 06/04/2021 00:44, Alex Hung wrote:
> ---
> fwts-test/sdev-0001/acpidump-0001.log | 17 ++++++------
> fwts-test/sdev-0001/acpidump-0002.log | 17 ++++++------
> fwts-test/sdev-0001/sdev-0001.log | 34 +++++++++++++-----------
> fwts-test/sdev-0001/sdev-0002.log | 38 ++++++++++++++-------------
> 4 files changed, 56 insertions(+), 50 deletions(-)
>
> diff --git a/fwts-test/sdev-0001/acpidump-0001.log b/fwts-test/sdev-0001/acpidump-0001.log
> index 2bca356b..dbd9eaeb 100644
> --- a/fwts-test/sdev-0001/acpidump-0001.log
> +++ b/fwts-test/sdev-0001/acpidump-0001.log
> @@ -24,12 +24,13 @@ FACP @ 0x00000000
> 00f0: 00 00 00 00 ....
>
> SDEV @ 0x0000000000000000
> - 0000: 53 44 45 56 72 00 00 00 01 36 49 4e 54 45 4c 20 SDEVr....6INTEL
> - 0010: 54 65 6d 70 6c 61 74 65 01 00 00 00 49 4e 54 4c Template....INTL
> - 0020: 29 09 17 20 00 01 2a 00 0c 00 16 00 22 00 08 00 ).. ..*....."...
> - 0030: 5c 5c 5f 53 42 5f 2e 50 43 49 30 2e 55 53 42 31 \\_SB_.PCI0.USB1
> - 0040: 2e 53 55 42 31 00 00 11 22 33 44 55 66 77 01 01 .SUB1..."3DUfw..
> - 0050: 24 00 10 00 20 00 10 00 04 00 14 00 10 00 11 22 $... .........."
> - 0060: 33 44 ee dd cc bb aa 55 66 77 88 99 aa bb cc dd 3D.....Ufw......
> - 0070: ee ff ..
> + 0000: 53 44 45 56 89 00 00 00 01 40 49 4E 54 45 4C 20 SDEV..... at INTEL
> + 0010: 54 65 6D 70 6C 61 74 65 01 00 00 00 49 4E 54 4C Template....INTL
> + 0020: 31 03 21 20 00 03 41 00 23 00 16 00 39 00 08 00 1.! ..A.#...9...
> + 0030: 10 00 13 00 00 00 00 00 01 00 03 02 05 04 07 06 ................
> + 0040: 09 08 0A 0B 0C 0D 0E 5C 5C 5F 53 42 5F 2E 50 43 .......\\_SB_.PC
> + 0050: 49 30 2E 55 53 42 31 2E 53 55 42 31 00 00 11 22 I0.USB1.SUB1..."
> + 0060: 33 44 55 66 77 01 01 24 00 10 00 20 00 10 00 04 3DUfw..$... ....
> + 0070: 00 14 00 10 00 11 22 33 44 EE DD CC BB AA 55 66 ......"3D.....Uf
> + 0080: 77 88 99 AA BB CC DD EE FF w........
>
> diff --git a/fwts-test/sdev-0001/acpidump-0002.log b/fwts-test/sdev-0001/acpidump-0002.log
> index 10628c5c..3e54c42a 100644
> --- a/fwts-test/sdev-0001/acpidump-0002.log
> +++ b/fwts-test/sdev-0001/acpidump-0002.log
> @@ -24,12 +24,13 @@ FACP @ 0x00000000
> 00f0: 00 00 00 00 ....
>
> SDEV @ 0x0000000000000000
> - 0000: 53 44 45 56 72 00 00 00 01 36 49 4e 54 45 4c 20 SDEVr....6INTEL
> - 0010: 54 65 6d 70 6c 61 74 65 01 00 00 00 49 4e 54 4c Template....INTL
> - 0020: 29 09 17 20 00 03 2a 00 0c 00 16 00 22 00 08 00 ).. ..*....."...
> - 0030: 5c 5c 5f 53 42 5f 2e 50 43 49 30 2e 55 53 42 31 \\_SB_.PCI0.USB1
> - 0040: 2e 53 55 42 31 00 00 11 22 33 44 55 66 77 01 05 .SUB1..."3DUfw..
> - 0050: 24 00 10 00 20 00 10 00 04 00 14 00 10 00 11 22 $... .........."
> - 0060: 33 44 ee dd cc bb aa 55 66 77 88 99 aa bb cc dd 3D.....Ufw......
> - 0070: ee ff ..
> + 0000: 53 44 45 56 89 00 00 00 01 40 49 4E 54 45 4C 20 SDEV..... at INTEL
> + 0010: 54 65 6D 70 6C 61 74 65 01 00 00 00 49 4E 54 4C Template....INTL
> + 0020: 31 03 21 20 00 05 41 00 23 00 16 00 39 00 08 00 1.! ..A.#...9...
> + 0030: 10 00 13 00 00 00 00 00 01 00 03 02 05 04 07 06 ................
> + 0040: 09 08 0A 0B 0C 0D 0E 5C 5C 5F 53 42 5F 2E 50 43 .......\\_SB_.PC
> + 0050: 49 30 2E 55 53 42 31 2E 53 55 42 31 00 00 11 22 I0.USB1.SUB1..."
> + 0060: 33 44 55 66 77 01 03 24 00 10 00 20 00 10 00 04 3DUfw..$... ....
> + 0070: 00 14 00 10 00 11 22 33 44 EE DD CC BB AA 55 66 ......"3D.....Uf
> + 0080: 77 88 99 AA BB CC DD EE FF w........
>
> diff --git a/fwts-test/sdev-0001/sdev-0001.log b/fwts-test/sdev-0001/sdev-0001.log
> index 8e5dce59..459fbd32 100644
> --- a/fwts-test/sdev-0001/sdev-0001.log
> +++ b/fwts-test/sdev-0001/sdev-0001.log
> @@ -3,24 +3,26 @@ sdev ----------------------------------------------------------
> sdev Test 1 of 1: Validate SDEV table.
> sdev SDEV Secure Devices Table:
> sdev ACPI Integrated Device (Type 0):
> -sdev Type: 0x00
> -sdev Flags: 0x01
> -sdev Length: 0x002a
> -sdev Device Id Offset: 0x000c
> -sdev Device Id Length: 0x0016
> -sdev Vendor Specific Data Offset: 0x0022
> -sdev Vendor Specific Data Length: 0x0008
> +sdev Type: 0x00
> +sdev Flags: 0x03
> +sdev Length: 0x0041
> +sdev Device Id Offset: 0x0023
> +sdev Device Id Length: 0x0016
> +sdev Vendor Specific Data Offset: 0x0039
> +sdev Vendor Specific Data Length: 0x0008
> +sdev Secure Access Components Offset: 0x0010
> +sdev Secure Access Components Length: 0x0013
> sdev
> sdev PCIe Endpoint Device (Type 1):
> -sdev Type: 0x01
> -sdev Flags: 0x01
> -sdev Length: 0x0024
> -sdev PCI Segment Number: 0x0010
> -sdev Start Bus Number: 0x0020
> -sdev PCI Path Offset: 0x0010
> -sdev PCI Path Length: 0x0004
> -sdev Vendor Specific Data Offset: 0x0014
> -sdev Vendor Specific Data Length: 0x0010
> +sdev Type: 0x01
> +sdev Flags: 0x01
> +sdev Length: 0x0024
> +sdev PCI Segment Number: 0x0010
> +sdev Start Bus Number: 0x0020
> +sdev PCI Path Offset: 0x0010
> +sdev PCI Path Length: 0x0004
> +sdev Vendor Specific Data Offset: 0x0014
> +sdev Vendor Specific Data Length: 0x0010
> sdev
> sdev
> sdev PASSED: Test 1, No issues found in SDEV table.
> diff --git a/fwts-test/sdev-0001/sdev-0002.log b/fwts-test/sdev-0001/sdev-0002.log
> index ff83c69c..00b85bfb 100644
> --- a/fwts-test/sdev-0001/sdev-0002.log
> +++ b/fwts-test/sdev-0001/sdev-0002.log
> @@ -3,28 +3,30 @@ sdev ----------------------------------------------------------
> sdev Test 1 of 1: Validate SDEV table.
> sdev SDEV Secure Devices Table:
> sdev ACPI Integrated Device (Type 0):
> -sdev Type: 0x00
> -sdev Flags: 0x03
> -sdev Length: 0x002a
> -sdev Device Id Offset: 0x000c
> -sdev Device Id Length: 0x0016
> -sdev Vendor Specific Data Offset: 0x0022
> -sdev Vendor Specific Data Length: 0x0008
> +sdev Type: 0x00
> +sdev Flags: 0x05
> +sdev Length: 0x0041
> +sdev Device Id Offset: 0x0023
> +sdev Device Id Length: 0x0016
> +sdev Vendor Specific Data Offset: 0x0039
> +sdev Vendor Specific Data Length: 0x0008
> +sdev Secure Access Components Offset: 0x0010
> +sdev Secure Access Components Length: 0x0013
> sdev FAILED [HIGH] SDEVReservedBitsNonZero: Test 1, SDEV Flags
> -sdev Bits [15..1] must be zero, got 0x03 instead
> +sdev Bits [15..2] must be zero, got 0x05 instead
> sdev
> sdev PCIe Endpoint Device (Type 1):
> -sdev Type: 0x01
> -sdev Flags: 0x05
> -sdev Length: 0x0024
> -sdev PCI Segment Number: 0x0010
> -sdev Start Bus Number: 0x0020
> -sdev PCI Path Offset: 0x0010
> -sdev PCI Path Length: 0x0004
> -sdev Vendor Specific Data Offset: 0x0014
> -sdev Vendor Specific Data Length: 0x0010
> +sdev Type: 0x01
> +sdev Flags: 0x03
> +sdev Length: 0x0024
> +sdev PCI Segment Number: 0x0010
> +sdev Start Bus Number: 0x0020
> +sdev PCI Path Offset: 0x0010
> +sdev PCI Path Length: 0x0004
> +sdev Vendor Specific Data Offset: 0x0014
> +sdev Vendor Specific Data Length: 0x0010
> sdev FAILED [HIGH] SDEVReservedBitsNonZero: Test 1, SDEV Flags
> -sdev Bits [15..1] must be zero, got 0x05 instead
> +sdev Bits [15..1] must be zero, got 0x03 instead
> sdev
> sdev
> sdev
>
Acked-by: Colin Ian King <colin.king at canonical.com>
More information about the fwts-devel
mailing list