ACK: [fwts PATCH v2 1/1] lib: enable /dev/mem access on aarch64

[Leif Lindholm]

On Thu, Oct 15, 2020 at 17:48:45 +0100, Colin Ian King wrote:
> On 15/10/2020 17:42, Heinrich Schuchardt wrote:
> > The SMBIOS3 table supplied by U-Boot cannot be read without mmap.
> > 
> > Cc: Leif Lindholm <leif at nuviainc.com>
> > Fixes: f36ff824d145 ("lib: disable /dev/mem access on aarch64")
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> > ---
> > v2:
> > 	Leif's email address has changed
> > ---
> >  src/lib/include/fwts.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/lib/include/fwts.h b/src/lib/include/fwts.h
> > index 6f13d262..a4163055 100644
> > --- a/src/lib/include/fwts.h
> > +++ b/src/lib/include/fwts.h
> > @@ -105,6 +105,7 @@
> >  #define FWTS_ARCH_AARCH64	1
> >  #define FWTS_HAS_ACPI	1
> >  #define FWTS_HAS_UEFI	1
> > +#define FWTS_USE_DEVMEM 1
> >  #endif
> > 
> >  #if defined(__s390x__)
> > --
> > 2.28.0
> > 
> 
> Unless Lief disagrees, I can't see why not, especially if it allows
> testing of the SMBIOS table.

Oh, Leif disagrees :)
(See other email.)

On which note, I think you missed an email I sent on this topic for
RISC-V a while back:
https://lists.ubuntu.com/archives/fwts-devel/2020-July/012143.html

Regards,

Leif

> Acked-by: Colin Ian King <colin.king at canonical.com>